chrome/browser/extensions/api/web_request/web_request_api.cc - Issue 14651017: Move RuntimeData and related permissions out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_permissions

Patch Set: Latest master Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/usb/usb_api.cc ('k') | chrome/browser/extensions/api/web_request/web_request_permissions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc

index 910a52f742e5c67da680efe43d0a92daa3ffec85..b6ea4b4d9e85de48778f67772da286003005188c 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc

@@ -43,6 +43,7 @@

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_messages.h"

#include "chrome/common/extensions/features/feature.h"

+#include "chrome/common/extensions/permissions/permissions_data.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/browser_message_filter.h"

#include "content/public/browser/browser_thread.h"

@@ -1997,7 +1998,8 @@ bool WebRequestAddEventListener::RunImpl() {

// http://www.example.com/bar/*.

// For this reason we do only a coarse check here to warn the extension

// developer if he does something obviously wrong.

- if (extension->GetEffectiveHostPermissions().is_empty()) {

+ if (extensions::PermissionsData::GetEffectiveHostPermissions(

+ extension).is_empty()) {

error_ = keys::kHostPermissionsRequired;

return false;

}