chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 14651017: Move RuntimeData and related permissions out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_permissions

Patch Set: Latest master Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index 365ae6421d459a76b18f686f0e0b2c7809e088de..33d628211a9d5223e63bb0669c59426ee3364717 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -47,6 +47,7 @@

#include "chrome/common/cancelable_task_tracker.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/extensions/api/downloads.h"

+#include "chrome/common/extensions/permissions/permissions_data.h"

#include "content/public/browser/download_interrupt_reasons.h"

#include "content/public/browser/download_item.h"

#include "content/public/browser/download_save_info.h"

@@ -806,7 +807,8 @@ bool DownloadsDownloadFunction::RunImpl() {

if (!download_url.is_valid() ||

(!download_url.SchemeIs("data") &&

download_url.GetOrigin() != GetExtension()->url().GetOrigin() &&

- !GetExtension()->HasHostPermission(download_url))) {

+ !extensions::PermissionsData::HasHostPermission(GetExtension(),

+ download_url))) {

error_ = download_extension_errors::kInvalidURLError;

return false;

}