Issue 14651015: Revert 198977 "Remove unused third_party/WebKit #includes from c..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14651015: Revert 198977 "Remove unused third_party/WebKit #includes from c..." (Closed)

Created:
7 years, 7 months ago by csharp

Modified:
7 years, 7 months ago

Reviewers:
jamesr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 198977 "Remove unused third_party/WebKit #includes from c..." Broke a lot of test from translate_manager_browsertest.cc on Mac and Linux > Remove unused third_party/WebKit #includes from chrome/browser > > BUG=237267 > > Review URL: https://chromiumcodereview.appspot.com/15026005 TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198992

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -0 lines)			Patch
M	trunk/src/chrome/browser/chrome_net_benchmarking_message_filter.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/translate/translate_manager_browsertest.cc	View	4 chunks	+5 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/ash/window_positioner_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csharp

7 years, 7 months ago (2013-05-08 20:59:35 UTC) #3

Message was sent while issue was closed.

On 2013/05/08 20:57:17, csharp wrote:
> Committed patchset #1 manually as r198992.

Builds that failed:
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%282%29/b...
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%...
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%...
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%...

Expand Messages | Collapse Messages