Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 14651009: Land Recent QUIC changes (Closed)

Created:
7 years, 7 months ago by ramant (doing other things)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC changes Implement header compression/decompression in ReliableQuicStream. Merge internal change: 44867738 QUIC: deflake proof_test. The current proof_test removes a byte from the start of the signature in order to make it invalid. However, the signature is a big-endian number and, ~1% of the time, the first byte will be zero - thus removing it doesn't change the number. This change adds a non-zero byte to the start of the signature instead. Merge internal change: 44803399 Replace calls to scoped_ptr(NULL) with calls to scoped_ptr(). Merge internal change: 44799980 Add a blank line in order to get the dependencies correct for rebuild. Merge internal change: 44796024 Fix "large integer implicitly truncated to unsigned type" Merge internal change: 44793986 QUIC: compress certificates. This change causes server certificates to be compressed using three tricks: 1) The client can advertise sets of common certificates that the server can then simply reference. This change contains "common certificate set 0", which is the set of the intermediates used twice or more in the Alexa top 5000. It's temporary because it's missing GIAG2 which we'll want to include soon. 2) The client can send 64-bit, FNV-1a hashes of certificates that it already has and the server can reference them by hash. 3) Otherwise, certifciates are gzip compressed with a dictionary that includes any certificates compressed using the previous two methods and a 1500 byte lump of common substrings. (Again, taken from the Alexa top 5000) POKE=1 Merge internal change: 44792710 R=mnaganov@chromium.org, rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198736 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198793

Patch Set 1 #

Patch Set 2 : use OS_POSIX and added missing NET_EXPORT_PRIVATE #

Patch Set 3 : use replace to assign 0xFF into a string #

Patch Set 4 : fix for andriod-dbg #

Patch Set 5 : Added cert files to whitelist #

Patch Set 6 : Fixed the alphabetical order #

Patch Set 7 : fix integer constant is too large for 'unsigned long' type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23900 lines, -139 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
A net/base/iovec.h View 1 2 3 4 5 6 1 chunk +18 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 6 chunks +16 lines, -0 lines 0 comments Download
A net/quic/crypto/cert_compressor.h View 1 2 3 4 5 6 1 chunk +55 lines, -0 lines 0 comments Download
A net/quic/crypto/cert_compressor.cc View 1 2 3 4 5 6 1 chunk +641 lines, -0 lines 0 comments Download
A net/quic/crypto/cert_compressor_test.cc View 1 2 3 4 5 6 1 chunk +140 lines, -0 lines 0 comments Download
A net/quic/crypto/common_cert_set.h View 1 2 3 4 5 6 1 chunk +62 lines, -0 lines 0 comments Download
A net/quic/crypto/common_cert_set.cc View 1 2 3 4 5 6 1 chunk +135 lines, -0 lines 0 comments Download
A net/quic/crypto/common_cert_set_0.c View 1 2 3 4 5 6 1 chunk +221 lines, -0 lines 0 comments Download
A net/quic/crypto/common_cert_set_1_50.inc View 1 2 3 4 5 6 1 chunk +9606 lines, -0 lines 0 comments Download
A net/quic/crypto/common_cert_set_51_100.inc View 1 2 3 4 5 6 1 chunk +11305 lines, -0 lines 0 comments Download
A net/quic/crypto/common_cert_set_test.cc View 1 2 3 4 5 6 1 chunk +109 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_handshake.h View 1 2 3 4 5 6 5 chunks +8 lines, -1 line 0 comments Download
M net/quic/crypto/crypto_handshake.cc View 1 2 3 4 5 6 10 chunks +37 lines, -30 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_config.cc View 1 2 3 4 5 6 5 chunks +20 lines, -33 lines 0 comments Download
M net/quic/crypto/null_encrypter.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A net/quic/crypto/proof_test.cc View 1 2 3 4 5 6 1 chunk +58 lines, -0 lines 0 comments Download
M net/quic/quic_bandwidth.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_framer.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 2 3 4 5 6 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 1 2 3 4 5 6 3 chunks +8 lines, -1 line 0 comments Download
M net/quic/quic_session.h View 1 2 3 4 5 6 5 chunks +17 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 1 2 3 4 5 6 2 chunks +19 lines, -0 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A net/quic/quic_spdy_compressor.h View 1 2 3 4 5 6 1 chunk +38 lines, -0 lines 0 comments Download
A net/quic/quic_spdy_compressor.cc View 1 2 3 4 5 6 1 chunk +50 lines, -0 lines 0 comments Download
A net/quic/quic_spdy_compressor_test.cc View 1 2 3 4 5 6 1 chunk +46 lines, -0 lines 0 comments Download
A net/quic/quic_spdy_decompressor.h View 1 2 3 4 5 6 1 chunk +64 lines, -0 lines 0 comments Download
A net/quic/quic_spdy_decompressor.cc View 1 2 3 4 5 6 1 chunk +138 lines, -0 lines 0 comments Download
A net/quic/quic_spdy_decompressor_test.cc View 1 2 3 4 5 6 1 chunk +57 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer.h View 1 2 3 4 5 6 3 chunks +17 lines, -2 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 1 2 3 4 5 6 3 chunks +84 lines, -2 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 2 3 4 5 6 3 chunks +187 lines, -0 lines 0 comments Download
M net/quic/quic_utils.h View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
M net/quic/quic_utils.cc View 1 2 3 4 5 6 3 chunks +36 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 2 3 4 5 6 5 chunks +32 lines, -5 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 2 3 4 5 6 5 chunks +177 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 1 2 3 4 5 6 2 chunks +241 lines, -32 lines 0 comments Download
A net/quic/spdy_utils.h View 1 2 3 4 5 6 1 chunk +23 lines, -0 lines 0 comments Download
A net/quic/spdy_utils.cc View 1 2 3 4 5 6 1 chunk +25 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 2 3 4 5 6 2 chunks +63 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 2 3 4 5 6 3 chunks +15 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 2 3 4 5 6 3 chunks +8 lines, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_reliable_server_stream_test.cc View 1 2 3 4 5 6 2 chunks +13 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M net/tools/quic/spdy_utils.h View 1 2 3 4 5 6 2 chunks +10 lines, -0 lines 0 comments Download
M net/tools/quic/spdy_utils.cc View 1 2 3 4 5 6 2 chunks +26 lines, -11 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 2 3 4 5 6 3 chunks +21 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
ramant (doing other things)
7 years, 7 months ago (2013-05-04 06:59:52 UTC) #1
Ryan Hamilton
Rubber stamp lgtm since all the underlying CLs lgtm
7 years, 7 months ago (2013-05-06 15:40:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14651009/35012
7 years, 7 months ago (2013-05-06 16:03:08 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=60190
7 years, 7 months ago (2013-05-06 17:14:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14651009/35012
7 years, 7 months ago (2013-05-06 17:58:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=60256
7 years, 7 months ago (2013-05-06 19:08:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14651009/35012
7 years, 7 months ago (2013-05-06 19:08:43 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=60293
7 years, 7 months ago (2013-05-06 20:39:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14651009/35012
7 years, 7 months ago (2013-05-06 21:05:31 UTC) #9
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=60353
7 years, 7 months ago (2013-05-06 22:07:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14651009/35012
7 years, 7 months ago (2013-05-06 22:34:46 UTC) #11
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=60411
7 years, 7 months ago (2013-05-06 23:45:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14651009/76001
7 years, 7 months ago (2013-05-07 00:38:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14651009/104001
7 years, 7 months ago (2013-05-07 01:47:43 UTC) #14
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=1723
7 years, 7 months ago (2013-05-07 01:56:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14651009/113008
7 years, 7 months ago (2013-05-07 01:59:58 UTC) #16
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=1726
7 years, 7 months ago (2013-05-07 02:11:22 UTC) #17
ramant (doing other things)
7 years, 7 months ago (2013-05-07 02:14:34 UTC) #18
ramant (doing other things)
torne@: could you take a look at the change for android_webview/tools/third_party_files_whitelist.txt? thanks raman
7 years, 7 months ago (2013-05-07 02:15:40 UTC) #19
mnaganov (inactive)
LGTM for android_webview/tools/third_party_files_whitelist.txt
7 years, 7 months ago (2013-05-07 08:23:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14651009/113008
7 years, 7 months ago (2013-05-07 09:18:47 UTC) #21
commit-bot: I haz the power
Change committed as 198736
7 years, 7 months ago (2013-05-07 16:28:25 UTC) #22
ramant (doing other things)
7 years, 7 months ago (2013-05-07 20:55:10 UTC) #23
Message was sent while issue was closed.
Committed patchset #7 manually as r198793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698