Issue 14651004: Revert "frames.h/cc cleanup"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14651004: Revert "frames.h/cc cleanup" (Closed)

Created:
7 years, 7 months ago by yurys

Modified:
7 years, 7 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "frames.h/cc cleanup" This reverts r14496 which broke tests in debug mode: Command: /mnt/data/b/build/slave/v8-linux-nosnap-debug/build/v8/out/Debug/cctest test-log/LogAccessorCallbacks --nobreak-on-abort --nodead-code-elimination --nofold-constants --enable-slow-asserts --debug-code --verify-heap --testing_serialization_file=/mnt/data/b/build/slave/v8-linux-nosnap-debug/build/v8/out/.serdes/serdes_LogAccessorCallbacks === cctest/test-log/LogCallbacks === --- stderr --- TBR=jkummerow@chromium.org BUG=None Committed: https://code.google.com/p/v8/source/detail?r=14502

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	src/frames.h	View		1 chunk	+3 lines, -5 lines	0 comments	Download
	M	src/frames.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 7 months ago (2013-04-30 16:51:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14502 (presubmit successful).

Expand Messages | Collapse Messages