Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 1465083002: Add unit test for non-leftmost GC mixin instance. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit test for non-leftmost GC mixin instance. Verify that deriving from a USING_GARBAGE_COLLECTED_MIXIN() annotated class is traced as expected. R=haraken BUG= Committed: https://crrev.com/baf05aeed31681a87d8eaf85df7f4813b9ab4aaa Cr-Commit-Position: refs/heads/master@{#361072}

Patch Set 1 #

Patch Set 2 : remove temporary, but broken isHeapObjectAlive() testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-22 22:01:44 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-23 02:41:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465083002/20001
5 years, 1 month ago (2015-11-23 06:19:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 06:59:46 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/baf05aeed31681a87d8eaf85df7f4813b9ab4aaa Cr-Commit-Position: refs/heads/master@{#361072}
5 years, 1 month ago (2015-11-23 07:00:35 UTC) #9
sof
5 years, 1 month ago (2015-11-23 07:14:20 UTC) #10
Message was sent while issue was closed.
Somewhat related, but the GC plugin check we added to insist that a
USING_GARBAGE_COLLECTED_MIXIN()-annotated class also defines a trace(), doesn't
serve a real purpose wrt correctness.

Powered by Google App Engine
This is Rietveld 408576698