Issue 1465013002: general completion contributor cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1465013002: general completion contributor cleanup (Closed)

Created:
5 years, 1 month ago by danrubel

Modified:
5 years, 1 month ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -12 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/completion_core.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/domain_completion_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/stress/replay/operation.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

danrubel

5 years, 1 month ago (2015-11-23 16:03:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b091bb0b18486d28f1d09b53b176d8b566c1e6a6 (presubmit successful).