Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 14650014: Add type checks to typed array property getters. (Closed)

Created:
7 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Add type checks to typed array property getters. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14538

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback: tests #

Patch Set 3 : Without rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M test/mjsunit/harmony/typedarrays.js View 1 2 4 chunks +33 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Lomov (no reviews)
Please take a look
7 years, 7 months ago (2013-05-03 08:35:56 UTC) #1
rossberg
https://codereview.chromium.org/14650014/diff/1/test/mjsunit/harmony/typedarrays.js File test/mjsunit/harmony/typedarrays.js (right): https://codereview.chromium.org/14650014/diff/1/test/mjsunit/harmony/typedarrays.js#newcode283 test/mjsunit/harmony/typedarrays.js:283: assertThrows(function() {d.get.call(o);}, TypeError); You could also check that it ...
7 years, 7 months ago (2013-05-03 09:43:27 UTC) #2
Dmitry Lomov (no reviews)
Thanks for the review! PTAL https://codereview.chromium.org/14650014/diff/1/test/mjsunit/harmony/typedarrays.js File test/mjsunit/harmony/typedarrays.js (right): https://codereview.chromium.org/14650014/diff/1/test/mjsunit/harmony/typedarrays.js#newcode283 test/mjsunit/harmony/typedarrays.js:283: assertThrows(function() {d.get.call(o);}, TypeError); On ...
7 years, 7 months ago (2013-05-03 09:53:44 UTC) #3
Dmitry Lomov (no reviews)
7 years, 7 months ago (2013-05-03 09:56:19 UTC) #4
rossberg
lgtm
7 years, 7 months ago (2013-05-03 09:58:30 UTC) #5
Dmitry Lomov (no reviews)
7 years, 7 months ago (2013-05-03 09:59:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r14538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698