src/frames.h - Issue 14650002: frames.h/cc cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.h

Issue 14650002: frames.h/cc cleanup (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.h

diff --git a/src/frames.h b/src/frames.h

index 678191b950a0172a37f62a78fb9533f977502613..4e78572c24d01cd1ea4c280c79b0e2c00db7555a 100644

--- a/src/frames.h

+++ b/src/frames.h

@@ -969,9 +969,8 @@ typedef JavaScriptFrameIteratorTemp<SafeStackFrameIterator>

class SafeStackTraceFrameIterator: public SafeJavaScriptFrameIterator {

public:

- explicit SafeStackTraceFrameIterator(Isolate* isolate,

- Address fp, Address sp,

- Address low_bound, Address high_bound);

+ SafeStackTraceFrameIterator(Isolate* isolate, Address fp, Address sp,

Jakob Kummerow 2013/04/30 13:30:31 nit: for method/ctor definitions, one line per arg

yurys 2013/04/30 14:37:05 Done.

+ Address low_bound, Address high_bound);

void Advance();

};

« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »