Issue 14650002: frames.h/cc cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14650002: frames.h/cc cleanup (Closed)

Created:
7 years, 7 months ago by yurys

Modified:
7 years, 7 months ago

Reviewers:
loislo, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

frames.h/cc cleanup BUG=None R=jkummerow@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14496

Patch Set 2 : Fixed formatting #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/frames.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
	M	src/frames.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://codereview.chromium.org/14650002/diff/1/src/frames.h File src/frames.h (right): https://codereview.chromium.org/14650002/diff/1/src/frames.h#newcode972 src/frames.h:972: SafeStackTraceFrameIterator(Isolate* isolate, Address fp, Address sp, nit: for ...

7 years, 7 months ago (2013-04-30 13:30:31 UTC) #3

yurys

https://codereview.chromium.org/14650002/diff/1/src/frames.h File src/frames.h (right): https://codereview.chromium.org/14650002/diff/1/src/frames.h#newcode972 src/frames.h:972: SafeStackTraceFrameIterator(Isolate* isolate, Address fp, Address sp, On 2013/04/30 13:30:31, ...

7 years, 7 months ago (2013-04-30 14:37:05 UTC) #4

yurys

7 years, 7 months ago (2013-04-30 14:37:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r14496 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14650002: frames.h/cc cleanup (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed formatting #

Messages