Issue 1464933003: Revert of Make specialized SrcOver XPFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1464933003: Revert of Make specialized SrcOver XPFactory (Closed)

Created:
5 years, 1 month ago by egdaniel

Modified:
5 years, 1 month ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Make specialized SrcOver XPFactory (patchset #3 id:40001 of https://codereview.chromium.org/1455273006/ ) Reason for revert: breaking some builds Original issue's description: > Make specialized SrcOver XPFactory > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/a7006d45217d128a94fa53cb4b827cca79bc7049 TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f234272cbdcbcd46be462317e75cd138999c9fe9

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -179 lines)			Patch
M	include/core/SkXfermode.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/gpu/effects/GrCustomXfermode.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/effects/GrPorterDuffXferProcessor.h	View	4 chunks	+4 lines, -47 lines	0 comments	Download
M	src/core/SkXfermode.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/core/SkXfermode_proccoeff.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkArithmeticMode.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrProcessor.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGr.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrCustomXfermode.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrPorterDuffXferProcessor.cpp	View	6 chunks	+34 lines, -115 lines	0 comments	Download
M	tests/GrPorterDuffTest.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464933003/1

5 years, 1 month ago (2015-11-20 23:12:45 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-11-20 23:13:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f234272cbdcbcd46be462317e75cd138999c9fe9

Expand Messages | Collapse Messages