Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: runtime/vm/precompiler.cc

Issue 1464933002: Don't ignore result of EnsureIsFinalized in Precompiler; update helper scripts to use dart_precompi… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/precompilation/test_linux.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/precompiler.cc
diff --git a/runtime/vm/precompiler.cc b/runtime/vm/precompiler.cc
index 3b70fc25499393a8c2c4b1ada95a60fef8272bd3..a990a0898600e0f84b131676e7b7bdc82bc692e3 100644
--- a/runtime/vm/precompiler.cc
+++ b/runtime/vm/precompiler.cc
@@ -124,12 +124,12 @@ void Precompiler::DoCompileAll(
void Precompiler::ClearAllCode() {
- class CodeCodeFunctionVisitor : public FunctionVisitor {
+ class ClearCodeFunctionVisitor : public FunctionVisitor {
void VisitFunction(const Function& function) {
function.ClearCode();
}
};
- CodeCodeFunctionVisitor visitor;
+ ClearCodeFunctionVisitor visitor;
VisitFunctions(&visitor);
}
@@ -588,7 +588,11 @@ void Precompiler::AddInstantiatedClass(const Class& cls) {
class_count_++;
cls.set_is_allocated(true);
- cls.EnsureIsFinalized(T);
+ error_ = cls.EnsureIsFinalized(T);
+ if (!error_.IsNull()) {
+ Jump(error_);
+ }
+
changed_ = true;
if (FLAG_trace_precompiler) {
@@ -923,7 +927,10 @@ void Precompiler::FinalizeAllClasses() {
if (cls.IsDynamicClass()) {
continue; // class 'dynamic' is in the read-only VM isolate.
}
- cls.EnsureIsFinalized(T);
+ error_ = cls.EnsureIsFinalized(T);
+ if (!error_.IsNull()) {
+ Jump(error_);
+ }
}
}
I->set_all_classes_finalized(true);
« no previous file with comments | « no previous file | tools/precompilation/test_linux.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698