Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1464933002: Don't ignore result of EnsureIsFinalized in Precompiler; update helper scripts to use dart_precompi… (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't ignore result of EnsureIsFinalized in Precompiler; update helper scripts to use dart_precompiled. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/6d69da223d4f1cad255213b9497e9bd012333297

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M runtime/vm/precompiler.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M tools/precompilation/test_linux.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/precompilation/test_linux_simarm.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/precompilation/test_macos.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 1 month ago (2015-11-20 22:28:42 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/1464933002/diff/1/tools/precompilation/test_linux.sh File tools/precompilation/test_linux.sh (right): https://codereview.chromium.org/1464933002/diff/1/tools/precompilation/test_linux.sh#newcode13 tools/precompilation/test_linux.sh:13: LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PWD" gdb -ex run --args ./out/DebugX64/dart_precompiled --run-precompiled-snapshot not_used.dart ...
5 years, 1 month ago (2015-11-23 08:46:38 UTC) #3
rmacnak
https://codereview.chromium.org/1464933002/diff/1/tools/precompilation/test_linux.sh File tools/precompilation/test_linux.sh (right): https://codereview.chromium.org/1464933002/diff/1/tools/precompilation/test_linux.sh#newcode13 tools/precompilation/test_linux.sh:13: LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PWD" gdb -ex run --args ./out/DebugX64/dart_precompiled --run-precompiled-snapshot not_used.dart On ...
5 years, 1 month ago (2015-11-23 17:31:13 UTC) #4
rmacnak
5 years, 1 month ago (2015-11-23 17:33:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6d69da223d4f1cad255213b9497e9bd012333297 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698