Android: Provide futimes() implementation using utimensat()

base/os_compat_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/os_compat_android.h"
 
+#include <asm/unistd.h>
 #include <errno.h>
 #include <math.h>
 #include <sys/stat.h>
+#include <sys/syscall.h>
 #include <time64.h>
 
 #include "base/rand_util.h"
 #include "base/stringprintf.h"
 #include "base/strings/string_piece.h"
 
+extern "C" {
 // There is no futimes() avaiable in Bionic, so we provide our own
 // implementation until it is there.
-extern "C" {
-
 int futimes(int fd, const struct timeval tv[2]) {
-  const std::string fd_path = base::StringPrintf("/proc/self/fd/%d", fd);
-  return utimes(fd_path.c_str(), tv);
+  // Convert timeval to timespec.
+  // timeval.usec is guaranteed to be less than one million.

[Mark Mentovai, 2013/06/06 13:37:44]

Guaranteed by whom? Any old user code might call this function and supply bogus
data.

For a faithful reimplementation of futimes, you should check the range, 0 <=
tv_usec < 1000000 as glibc does, and set errno to EINVAL and return -1 if not in
range. Why? Because there’s no guarantee that user code actually limits tv_usec
to the right range, and if a value comes in that’s in the wrong range, you need
to catch it before integer multiplication might transform it into a tv_nsec
value that actually is in range.

[nilesh, 2013/06/06 19:03:14]

Thanks. Done.

+  struct timespec ts[2];
+  ts[0].tv_sec = tv[0].tv_sec;

[Mark Mentovai, 2013/06/06 13:37:44]

tv is allowed to be NULL, in which case you would pass NULL to utimensat in
place of ts. You should handle this to implement futimes fully.

[nilesh, 2013/06/06 19:03:14]

Done.

+  ts[0].tv_nsec = tv[0].tv_usec * 1000;

[Mark Mentovai, 2013/06/06 13:37:44]

Normally you could use TIMEVAL_TO_TIMESPEC(&tv, &ts); but I guess Bionic doesn’t
have that either.

[nilesh, 2013/06/06 19:03:14]

You are right. TIMEVAL_TO_TIMESPEC is not avialable in the ndk.

+  ts[1].tv_sec = tv[1].tv_sec;
+  ts[1].tv_nsec = tv[1].tv_usec * 1000;
+  return syscall(__NR_utimensat, fd, NULL, ts, 0);
 }
 
 // Android has only timegm64() and no timegm().
 // We replicate the behaviour of timegm() when the result overflows time_t.
 time_t timegm(struct tm* const t) {
   // time_t is signed on Android.
   static const time_t kTimeMax = ~(1 << (sizeof(time_t) * CHAR_BIT - 1));
   static const time_t kTimeMin = (1 << (sizeof(time_t) * CHAR_BIT - 1));
   time64_t result = timegm64(t);
   if (result < kTimeMin || result > kTimeMax)
@@ skipping 113 matching lines @@
       // The directory doesn't exist, but an error occured
       return NULL;
     }
   }
 
   // We reached the max number of tries.
   return NULL;
 }
 
 }  // extern "C"