Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1464883002: update dartdoc rev in DEPS (Closed)

Created:
5 years, 1 month ago by keertip
Modified:
5 years, 1 month ago
Reviewers:
pquitslund, kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (2 generated)
keertip
5 years, 1 month ago (2015-11-20 18:43:40 UTC) #2
pquitslund
lgtm
5 years, 1 month ago (2015-11-20 18:44:10 UTC) #3
keertip
Committed patchset #1 (id:1) manually as f808568c8c32bb7436f1d90b926b6931541ccb16 (presubmit successful).
5 years, 1 month ago (2015-11-20 18:49:54 UTC) #4
kevmoo
5 years, 1 month ago (2015-11-20 19:30:47 UTC) #6
Message was sent while issue was closed.
Thansk! DBQ

https://codereview.chromium.org/1464883002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1464883002/diff/1/DEPS#newcode53
DEPS:53: "dartdoc_rev" : "@f6d2ed47f3210a813e697bf9c0d271a1bd5267f1",
Could we move to tags here? – It'd be easier to tell at a glance what version
we're at

Powered by Google App Engine
This is Rietveld 408576698