Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 146483002: Add a UseCounter for the HTMLSourceElement.media IDL attribute (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, watchdog-blink-watchlist_google.com, dglazkov+blink, arv+blink, adamk+blink_chromium.org, Inactive
Visibility:
Public.

Description

Add a UseCounter for the HTMLSourceElement.media IDL attribute The content attribute no longer does anything, so the IDL attribute should also be removed as soon as the usage allows. BUG=338197 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166044

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSourceElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
Adam, can you take this one as well? This needs to be committed after https://codereview.chromium.org/146483002/ ...
6 years, 11 months ago (2014-01-27 02:06:39 UTC) #1
adamk
You'll need an IDL owner here, adding eseidel.
6 years, 10 months ago (2014-01-28 23:50:20 UTC) #2
eseidel
lgtm
6 years, 10 months ago (2014-01-29 01:17:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/146483002/1
6 years, 10 months ago (2014-01-29 01:17:46 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-01-29 01:17:51 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 01:23:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/146483002/60001
6 years, 10 months ago (2014-01-29 02:28:51 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 06:08:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/146483002/60001
6 years, 10 months ago (2014-01-29 17:00:20 UTC) #9
commit-bot: I haz the power
Change committed as 166044
6 years, 10 months ago (2014-01-29 18:54:04 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 18:54:28 UTC) #11
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698