Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 1464783002: Disables MinorGC from collecting object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated to allow minor GC to collect object wrappers without references. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index c3b4cc8eb022f32066119c36b08e2de4fc941a77..b77f24b5578e064f72f99c3f7f88374511da2600 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -143,6 +143,13 @@ public:
v8::Persistent<v8::Object>::Cast(*value).MarkActive();
return;
}
+ } else {
+ // If there are any references to this object mark it as active.
+ // Current MinorGC pass does not handle references.
+ if (type->visitDOMWrapperFunction) {
haraken 2015/11/24 12:59:08 Unfortunately this check is not correct. type->vis
mythria 2015/11/24 14:21:44 Thank you for your review. Reverted this change.
+ v8::Persistent<v8::Object>::Cast(*value).MarkActive();
mythria 2015/11/24 11:50:19 Would this check be sufficient to filter out all o
+ return;
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698