Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: pkg/compiler/lib/src/common/resolution.dart

Issue 1464773002: Remove WorldImpact from caches when no longer needed. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/common/resolution.dart
diff --git a/pkg/compiler/lib/src/common/resolution.dart b/pkg/compiler/lib/src/common/resolution.dart
index 727f3aa8632f19128a7d4b16302b1c02ff4dd192..952a1f413c051d973b39301639e802a97ae831ba 100644
--- a/pkg/compiler/lib/src/common/resolution.dart
+++ b/pkg/compiler/lib/src/common/resolution.dart
@@ -186,8 +186,16 @@ abstract class Resolution {
DartType resolveTypeAnnotation(Element element, TypeAnnotation node);
bool hasBeenResolved(Element element);
+
+ /// Returns the precomputed [WorldImpact] for [element].
WorldImpact getWorldImpact(Element element);
+
+ /// Computes the [WorldImpact] for [element].
WorldImpact computeWorldImpact(Element element);
+
+ /// Removes the [WorldImpact] for [element] from the resolution cache. Later
+ /// calls to [getWorldImpact] or [computeWorldImpact] returns an empty impact.
+ void uncacheWorldImpact(Element element);
}
// TODO(johnniwinther): Rename to `Parser` or `ParsingContext`.

Powered by Google App Engine
This is Rietveld 408576698