Remove WorldImpact from caches when no longer needed.

Remove WorldImpact from caches when no longer needed.

BUG=
R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/ecea5e5dc047f37fc16894bbc175ac752c9e0744

Reverted:  https://github.com/dart-lang/sdk/commit/b28df3dc5d1026f4b7bbe8e41a542e79b4860656

This test fails:
python tools/test.py -mrelease -cdart2js -rd8 --minified --dart2js-batch --host-checked -t960 dart2js_extra/deferred/deferred_function_test

Committed: https://github.com/dart-lang/sdk/commit/8a4995dfb75247197df8d407f4426b9c6ece08d5

[Johnni Winther, 2015-11-20 11:23:00]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2015-11-20 12:13:20]

LGTM

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:3113: if (impactUse ==
ResolutionEnqueuer.IMPACT_USE) {
It would be nice if we could do this switching only once.

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/world_impact.dart (right):

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:177: class ImpactUse {
dartdoc

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:185: class ImpactStrategy {
Consider if this can be named more descriptively.

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:185: class ImpactStrategy {
dartdoc

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:198: abstract class
WorldImpactVisitor {
dartdoc

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:204: // TODO(johnniwinther):
Remove these when we get anonymous local classes.
Don't hold your breath though ;)

[Johnni Winther, 2015-11-20 13:49:36]

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:3113: if (impactUse ==
ResolutionEnqueuer.IMPACT_USE) {
On 2015/11/20 12:13:19, sigurdm wrote:
> It would be nice if we could do this switching only once.

Added a TODO.

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/world_impact.dart (right):

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:177: class ImpactUse {
On 2015/11/20 12:13:19, sigurdm wrote:
> dartdoc

Done + Renamed to ImpactUseCase.

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:185: class ImpactStrategy {
On 2015/11/20 12:13:19, sigurdm wrote:
> dartdoc

Done.

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:185: class ImpactStrategy {
On 2015/11/20 12:13:19, sigurdm wrote:
> Consider if this can be named more descriptively.

Acknowledged.

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:198: abstract class
WorldImpactVisitor {
On 2015/11/20 12:13:19, sigurdm wrote:
> dartdoc

Done.

https://codereview.chromium.org/1464773002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_impact.dart:204: // TODO(johnniwinther):
Remove these when we get anonymous local classes.
On 2015/11/20 12:13:19, sigurdm wrote:
> Don't hold your breath though ;)

Acknowledged.

[Johnni Winther, 2015-11-20 14:16:35]

Committed patchset #2 (id:20001) manually as
ecea5e5dc047f37fc16894bbc175ac752c9e0744 (presubmit successful).

[sra1, 2015-11-20 23:28:23]

Description was changed from

==========
Remove WorldImpact from caches when no longer needed.

BUG=
R=sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ecea5e5dc047f37fc16894bbc175ac752c9e0744
==========

to

==========
Remove WorldImpact from caches when no longer needed.

BUG=
R=sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ecea5e5dc047f37fc16894bbc175ac752c9e0744

Reverted: 
https://github.com/dart-lang/sdk/commit/b28df3dc5d1026f4b7bbe8e41a542e79b4860656

This test fails:
python tools/test.py -mrelease -cdart2js -rd8 --minified --dart2js-batch
--host-checked -t960 dart2js_extra/deferred/deferred_function_test
==========

[Johnni Winther, 2015-11-23 12:50:57]

PTAL @ the last patch

[sigurdm, 2015-11-23 13:09:42]

LGTM

[Johnni Winther, 2015-11-23 14:51:58]

Committed patchset #4 (id:60001) manually as
8a4995dfb75247197df8d407f4426b9c6ece08d5 (presubmit successful).