During presubmit, look in parent directories for buildtools/checkdeps.

During presubmit, look in parent directories for buildtools/checkdeps.

This may be useful when PDFium is not a standalone checkout.

R=hans@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/814000d7876df07a03a320f9eae8af5da7b340c5

[Lei Zhang, 2015-11-20 02:57:42]

thestig@chromium.org changed reviewers:
+ hans@chromium.org

[Lei Zhang, 2015-11-20 02:57:42]

https://codereview.chromium.org/1464733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1464733002/diff/1/PRESUBMIT.py#newcode27
PRESUBMIT.py:27: if checkdeps_basepath ==
input_api.os_path.dirname(checkdeps_basepath):
Well, in theory, /buildtools/checkdeps may contain the checkdeps we are looking
for, but really, that's not gonna happen.

[hans, 2015-11-20 03:26:28]

https://codereview.chromium.org/1464733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1464733002/diff/1/PRESUBMIT.py#newcode29
PRESUBMIT.py:29: checkdeps_basepath =
input_api.os_path.dirname(checkdeps_basepath)
Sorry for being a little slow here.. how does this line work? Does it take
checkdeps_basepath to the parent directory?

[Lei Zhang, 2015-11-20 03:29:20]

https://codereview.chromium.org/1464733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1464733002/diff/1/PRESUBMIT.py#newcode29
PRESUBMIT.py:29: checkdeps_basepath =
input_api.os_path.dirname(checkdeps_basepath)
On 2015/11/20 03:26:28, hans wrote:
> Sorry for being a little slow here.. how does this line work? Does it take
> checkdeps_basepath to the parent directory?

It's essentially: foo = os.path.dirname(foo)
https://docs.python.org/2/library/os.path.html

[hans, 2015-11-20 03:52:21]

lgtm

https://codereview.chromium.org/1464733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1464733002/diff/1/PRESUBMIT.py#newcode29
PRESUBMIT.py:29: checkdeps_basepath =
input_api.os_path.dirname(checkdeps_basepath)
On 2015/11/20 03:29:19, Lei Zhang wrote:
> On 2015/11/20 03:26:28, hans wrote:
> > Sorry for being a little slow here.. how does this line work? Does it take
> > checkdeps_basepath to the parent directory?
> 
> It's essentially: foo = os.path.dirname(foo)
> https://docs.python.org/2/library/os.path.html

Ah, I get it now, thanks.

[Lei Zhang, 2015-11-20 05:37:50]

Committed patchset #1 (id:1) manually as
814000d7876df07a03a320f9eae8af5da7b340c5 (presubmit successful).