Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1464693002: Tiny linear gradient GM (Closed)

Created:
5 years, 1 month ago by f(malita)
Modified:
5 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Tiny linear gradient GM A GM to expose issues with vertical linear gradients when points and/or positions are too close. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/8b78bd6d5b39fe8ef407c4b59b1be8421e58d665

Patch Set 1 #

Patch Set 2 : bump isize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M gm/gradients.cpp View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464693002/1
5 years, 1 month ago (2015-11-20 00:09:44 UTC) #2
f(malita)
5 years, 1 month ago (2015-11-20 00:14:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464693002/20001
5 years, 1 month ago (2015-11-20 00:15:24 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-20 00:15:25 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 1 month ago (2015-11-20 06:15:06 UTC) #8
reed1
lgtm
5 years, 1 month ago (2015-11-20 15:48:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464693002/20001
5 years, 1 month ago (2015-11-20 15:48:32 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 21:58:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8b78bd6d5b39fe8ef407c4b59b1be8421e58d665

Powered by Google App Engine
This is Rietveld 408576698