Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1464663003:
Use IsRunningInMojoShell in GpuProcessTransportFactory (Closed)
|
Created:
5 years, 1 month ago by rjkroege Modified:
5 years ago Reviewers:
ccameron CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse IsRunningInMojoShell in GpuProcessTransportFactory
Mus+ash changes to GpuProcessTransportFactory for Chrome rendering under a
mojo shell checked the command line directly to enable mojo shell mode
because IsRunningInMojoShell wasn't available. Since it is now, use it.
Committed: https://crrev.com/c810c58eb97acfa92c1f6018082ccabf2df19930
Cr-Commit-Position: refs/heads/master@{#361247}
Patch Set 1 #
Messages
Total messages: 19 (8 generated)
rjkroege@chromium.org changed reviewers: + ccameron@chromium.org
Per discussion on earlier change. Now fixed. PTAL.
oh - lgtm
The CQ bit was checked by rjkroege@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464663003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by rjkroege@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464663003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rjkroege@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464663003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rjkroege@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464663003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c810c58eb97acfa92c1f6018082ccabf2df19930 Cr-Commit-Position: refs/heads/master@{#361247} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
