chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc - Issue 14646041: Allow virtual keyboard window to access audio stream and speech api for voice input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

Issue 14646041: Allow virtual keyboard window to access audio stream and speech api for voice input (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add view type Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

diff --git a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

index 02726bec76e417ba5f34d91767db20a8073144cb..4e835834b6f8c8190df3cf86f1921e058c1c1b8c 100644

--- a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

+++ b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

@@ -549,7 +549,8 @@ void ChromeSpeechRecognitionManagerDelegate::CheckRenderViewType(

// Right now the extension popup closes and dismisses immediately on user

// click.

if (view_type == extensions::VIEW_TYPE_TAB_CONTENTS ||

- view_type == extensions::VIEW_TYPE_APP_SHELL) {

+ view_type == extensions::VIEW_TYPE_APP_SHELL ||

+ view_type == extensions::VIEW_TYPE_VIRTUAL_KEYBOARD) {

// If it is a tab, we can show the speech input bubble or ask for

// permission.

« no previous file with comments | « no previous file | chrome/browser/ui/ash/ash_keyboard_controller_proxy.h » ('j') | extensions/common/view_type.h » ('J')