Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.h

Issue 14646034: Add onfocuschange to the Extended Search API, with associated isFocused attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix indent issues. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_edit_model.h
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.h b/chrome/browser/ui/omnibox/omnibox_edit_model.h
index 6b30c2598cf946d30e5ad691b052f040943cd2ac..d2f40d206c9fe15b0011f2fe0a31506d67082e4d 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.h
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.h
@@ -34,21 +34,6 @@ class Image;
class Rect;
}
-// Reasons why the Omnibox focus state could change.
samarth 2013/05/15 19:05:53 This shouldn't need to change anymore, right?
Donn Denman 2013/05/20 23:48:14 True. However, I'd argue that it's better this wa
-enum OmniboxFocusChangeReason {
- // Includes any explicit changes to focus. (e.g. user clicking to change
- // focus, user tabbing to change focus, any explicit calls to SetFocus,
- // etc.)
- OMNIBOX_FOCUS_CHANGE_EXPLICIT,
-
- // Focus changed to restore state from a tab the user switched to.
- OMNIBOX_FOCUS_CHANGE_TAB_SWITCH,
-
- // Focus changed because user started typing. This only happens when focus
- // state is INVISIBLE (and this results in a change to VISIBLE).
- OMNIBOX_FOCUS_CHANGE_TYPING,
-};
-
// Reasons why the Omnibox could change into keyword mode.
// These numeric values are used in UMA logs; do not change them.
enum EnteredKeywordModeMethod {
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_controller.h » ('j') | chrome/browser/ui/search/instant_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698