Add onfocuschange to the Extended Search API, with associated isFocused attribute.

chrome/browser/ui/search/instant_controller.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/instant_controller.h"
 
 #include <iterator>
 
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
@@ skipping 916 matching lines @@
     return;
 
   // Tell the page if the key capture mode changed unless the focus state
   // changed because of TYPING. This is because in that case, the browser hasn't
   // really stopped capturing key strokes.
   //
   // (More practically, if we don't do this check, the page would receive
   // onkeycapturechange before the corresponding onchange, and the page would
   // have no way of telling whether the keycapturechange happened because of
   // some actual user action or just because they started typing.)
   if (extended_enabled_ && GetOverlayContents() &&

[samarth, 2013/05/13 20:56:53]

Just need to check extended_enabled_ here. The GetOverlayContents() check is
leftover from before and doesn't really apply anymore. The reason check should
be moved to the searchbox.cc code (see comments there).

[Donn Denman, 2013/05/13 23:44:50]

Done.

       reason != OMNIBOX_FOCUS_CHANGE_TYPING) {
-    const bool is_key_capture_enabled =
-        omnibox_focus_state_ == OMNIBOX_FOCUS_INVISIBLE;
     if (overlay_)
-      overlay_->KeyCaptureChanged(is_key_capture_enabled);
+      overlay_->KeyCaptureChanged(omnibox_focus_state_, reason);
     if (instant_tab_)
-      instant_tab_->KeyCaptureChanged(is_key_capture_enabled);
+      instant_tab_->KeyCaptureChanged(omnibox_focus_state_, reason);
   }
 
   if (state == OMNIBOX_FOCUS_VISIBLE && old_focus_state == OMNIBOX_FOCUS_NONE) {
     // If the user explicitly focused the omnibox, then create the overlay if
     // it doesn't exist. If we're using a fallback overlay, try loading the
     // remote overlay again.
     if (!overlay_ || (overlay_->IsLocal() && !use_local_page_only_))
       ResetOverlay(GetInstantURL());
   } else if (state == OMNIBOX_FOCUS_NONE &&
              old_focus_state != OMNIBOX_FOCUS_NONE) {
@@ skipping 199 matching lines @@
     const content::WebContents* contents) {
   if (!extended_enabled_)
     return;
 
   // Update theme info so that the page picks it up.
   browser_->UpdateThemeInfo();
 
   // Ensure the searchbox API has the correct initial state.
   if (IsContentsFrom(overlay(), contents)) {
     overlay_->SetDisplayInstantResults(instant_enabled_);
-    overlay_->KeyCaptureChanged(
-        omnibox_focus_state_ == OMNIBOX_FOCUS_INVISIBLE);
+    overlay_->KeyCaptureChanged(omnibox_focus_state_,
+        OMNIBOX_FOCUS_CHANGE_INIT);

[samarth, 2013/05/13 20:56:53]

Don't need a new INIT value.  OMNIBOX_FOCUS_CHANGE_EXPLICIT is good enough.

[samarth, 2013/05/13 21:01:10]

Actually, we should be saving the reason inside InstantController like we do
omnibox_focus_state_ so we can send the correct value to the page.

[Donn Denman, 2013/05/13 23:44:50]

Done.

[Donn Denman, 2013/05/13 23:44:50]

Done.

     overlay_->SetOmniboxBounds(omnibox_bounds_);
     overlay_->InitializeFonts();
   } else if (IsContentsFrom(ntp(), contents)) {
     ntp_->SetDisplayInstantResults(instant_enabled_);
     ntp_->SetOmniboxBounds(omnibox_bounds_);
     ntp_->InitializeFonts();
   } else {
     NOTREACHED();
   }
   StartListeningToMostVisitedChanges();
@@ skipping 358 matching lines @@
   }
 }
 
 void InstantController::UpdateInfoForInstantTab() {
   if (instant_tab_) {
     browser_->UpdateThemeInfo();
     instant_tab_->SetDisplayInstantResults(instant_enabled_);
     instant_tab_->SetOmniboxBounds(omnibox_bounds_);
     instant_tab_->InitializeFonts();
     StartListeningToMostVisitedChanges();
-    instant_tab_->KeyCaptureChanged(
-        omnibox_focus_state_ == OMNIBOX_FOCUS_INVISIBLE);
+    instant_tab_->KeyCaptureChanged(omnibox_focus_state_,
+        OMNIBOX_FOCUS_CHANGE_INIT);  // TODO(donnd): right reason?

[samarth, 2013/05/13 21:01:10]

Likewise, here.

[Donn Denman, 2013/05/13 23:44:50]

Done.

   }
 }
 
 void InstantController::HideOverlay() {
   HideInternal();
   ReloadOverlayIfStale();
 }
 
 void InstantController::HideInternal() {
   LOG_INSTANT_DEBUG_EVENT(this, "Hide");
@@ skipping 250 matching lines @@
 
   result->transition = match.transition;
   result->relevance = match.relevance;
   result->autocomplete_match_index = autocomplete_match_index;
 
   DVLOG(1) << "    " << result->relevance << " " << result->type << " "
       << result->provider << " " << result->destination_url << " '"
       << result->description << "' '" << result->search_query << "' "
       << result->transition <<  " " << result->autocomplete_match_index;
 }