Issue 14646033: Fix and simplify unbundled v8.gyp:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14646033: Fix and simplify unbundled v8.gyp: (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.

Modified:
7 years, 7 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix and simplify unbundled v8.gyp: - use shim_headers.gypi instead of expanding it inline - enable host and target toolsets unconditionally, they're needed as deps (and make no difference anyway) BUG=226860 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199063

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -51 lines)			Patch
	M	build/linux/unbundle/v8.gyp	View		2 chunks	+12 lines, -51 lines	0 comments	Download

Total messages: 3 (0 generated)

Paweł Hajdan Jr.

In case you wonder why this patch is separate from the other one: I thought ...

7 years, 7 months ago (2013-05-08 23:38:48 UTC) #1

Paweł Hajdan Jr.

7 years, 7 months ago (2013-05-09 00:02:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r199063 (presubmit successful).