Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 1464603003: Use std::tie() for operator< in ui/ (Closed)

Created:
5 years, 1 month ago by jsbell
Modified:
5 years, 1 month ago
Reviewers:
danakj, benwells, Matt Giuca
CC:
chromium-reviews, tfarina, cc-bugs_chromium.org, Matt Giuca, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::tie() for operator< in ui/ Simplify the code for operator< when comparing multiple members using a common std::tie idiom. BUG=555171 R=danakj@chromium.org,benwells@chromium.org Committed: https://crrev.com/7faa086b0179eea33c7cb9ded9964dc560ca42bd Cr-Commit-Position: refs/heads/master@{#360706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M ui/app_list/views/apps_grid_view.h View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/gfx/geometry/point.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/geometry/point_f.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/paint_vector_icon.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jsbell
danakj@ - can you review ui/gfx? benwells@ - can you review ui/app_list ?
5 years, 1 month ago (2015-11-19 22:33:21 UTC) #1
danakj
LGTM thanks
5 years, 1 month ago (2015-11-19 23:08:00 UTC) #2
Matt Giuca
app_list lgtm (on behalf of benwells).
5 years, 1 month ago (2015-11-19 23:45:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464603003/1
5 years, 1 month ago (2015-11-20 01:19:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 01:27:03 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 01:27:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7faa086b0179eea33c7cb9ded9964dc560ca42bd
Cr-Commit-Position: refs/heads/master@{#360706}

Powered by Google App Engine
This is Rietveld 408576698