Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 14646029: Removing branching code for bubble/dialog field trial. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index 3891458ac6285e26cb4c26b6caf5f4ff9194c315..6d22c46aa5160f6f622790ba7a366ffd47165f12 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -1107,16 +1107,6 @@ void OneClickSigninHelper::DidStopLoading(
<< " auto_accept=" << auto_accept_
<< " source=" << source_;
- const char kSignInToChromeDialogFieldTrialName[] =
- "SignInToChromeConfirmation";
- const char kSignInConfirmBubbleGroupName[] = "Bubble";
- BrowserWindow::OneClickSigninBubbleType bubble_type;
- if (base::FieldTrialList::FindFullName(kSignInToChromeDialogFieldTrialName) ==
- kSignInConfirmBubbleGroupName)
- bubble_type = BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE;
- else
- bubble_type = BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_MODAL_DIALOG;
-
switch (auto_accept_) {
case AUTO_ACCEPT_NONE:
if (SyncPromoUI::UseWebBasedSigninFlow() && showing_signin_)
@@ -1127,7 +1117,7 @@ void OneClickSigninHelper::DidStopLoading(
LogOneClickHistogramValue(one_click_signin::HISTOGRAM_WITH_DEFAULTS);
SigninManager::DisableOneClickSignIn(profile);
browser->window()->ShowOneClickSigninBubble(
- bubble_type,
+ BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_MODAL_DIALOG,
UTF8ToUTF16(email_),
string16(), /* no error message to display */
base::Bind(&StartSync,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698