Get a backtrace in Chrome for Android.

Get a backtrace in Chrome for Android.

BUG=229352
R=digit@chromium.org, digit@google.com, willchan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198128

[Dai Mikurube (NOT FULLTIME), 2013-04-30 16:40:20]

Could you take a look, digit?

(Cc:) willchan, could you take OWNER's look when digit says ok?

[digit, 2013-04-30 16:58:13]

just a few nits, lgtm :)

https://codereview.chromium.org/14646012/diff/1/base/debug/stack_trace_androi...
File base/debug/stack_trace_android.cc (right):

https://codereview.chromium.org/14646012/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:20: // See Bionic's
libc/bionic/debug_stacktrace.cpp.
Maybe file a bug to track this and put a reference here about it?

https://codereview.chromium.org/14646012/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:49: // The first stack frame is get_backtrace
itself.  Skip it.
I'd suggest replacing "get_backtrace" by "this function" instead to make this
copied comment less confusing :-)

[Dai Mikurube (NOT FULLTIME), 2013-04-30 17:15:23]

Thanks, digit!  Done them.

https://codereview.chromium.org/14646012/diff/1/base/debug/stack_trace_androi...
File base/debug/stack_trace_android.cc (right):

https://codereview.chromium.org/14646012/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:20: // See Bionic's
libc/bionic/debug_stacktrace.cpp.
On 2013/04/30 16:58:13, digit wrote:
> Maybe file a bug to track this and put a reference here about it?

Done.

https://codereview.chromium.org/14646012/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:49: // The first stack frame is get_backtrace
itself.  Skip it.
On 2013/04/30 16:58:13, digit wrote:
> I'd suggest replacing "get_backtrace" by "this function" instead to make this
> copied comment less confusing :-)

Done.

[Dai Mikurube (NOT FULLTIME), 2013-04-30 17:16:04]

+willchan as a reviewer.

[willchan no longer on Chromium, 2013-04-30 17:35:18]

lgtm

[Dai Mikurube (NOT FULLTIME), 2013-04-30 17:38:39]

Thanks!  Checking the box...

[commit-bot: I haz the power, 2013-04-30 17:38:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14646012/7002

[Dai Mikurube (NOT FULLTIME), 2013-04-30 17:49:19]

Hmm, Android's Clang doesn't have _Unwind_GetIP?  I'll take another look
later...

[commit-bot: I haz the power, 2013-04-30 17:52:06]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Dai Mikurube (NOT FULLTIME), 2013-05-01 10:44:24]

Added a workaround for Clang for ARM.  android_clang_dbg succeeded.

Could you take another look?

[digit1, 2013-05-02 16:01:40]

Damn. lgtm

[Dai Mikurube (NOT FULLTIME), 2013-05-02 16:15:49]

Thanks!  committing.

[commit-bot: I haz the power, 2013-05-02 16:16:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14646012/20001

[commit-bot: I haz the power, 2013-05-02 16:54:06]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-03 00:27:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14646012/20001

[commit-bot: I haz the power, 2013-05-03 07:53:28]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-03 09:25:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14646012/20001

[commit-bot: I haz the power, 2013-05-03 11:38:14]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-03 11:40:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14646012/20001

[commit-bot: I haz the power, 2013-05-03 13:54:31]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Dai Mikurube (NOT FULLTIME), 2013-05-03 14:22:51]

The linux_chromeos error must not be by this patch since stack_trace_android.cc
is never compiled in linux_chromeos.

will dcommit...

[Dai Mikurube (NOT FULLTIME), 2013-05-03 16:36:48]

Committed patchset #5 manually as r198128 (presubmit successful).