Adding public API method on SkImage for extracting the GPU texture handle.

Adding public API method on SkImage for extracting the GPU texture handle.

TEST=Surface unit test

Committed: https://code.google.com/p/skia/source/detail?r=8945

[Justin Novosad, 2013-04-30 14:52:12]

PTAL

[reed1, 2013-04-30 15:09:35]

The plumbing style seems fine, but we should return a GrTexture* instead of an
int, since that object already has a way to query its "native" texture
reference, and it can know how to flush our batched rendering into it.

Adding Brian to give more color.

[bsalomon, 2013-04-30 15:12:52]

On 2013/04/30 15:09:35, reed1 wrote:
> The plumbing style seems fine, but we should return a GrTexture* instead of an
> int, since that object already has a way to query its "native" texture
> reference, and it can know how to flush our batched rendering into it.
> 
> Adding Brian to give more color.

Here's my proposal:

Make SkImage have a GrTexture* getTexture() method.
GrTexture already has getTextureHandle() to get the ID.

We could call texture->getContext()->flush() to flush the GrContext. But I'd
propose adding a GrSurface::flush() call which today just calls
this->getContext()->flush(). However, in the future we may be able to do a more
targeted flush.

[Justin Novosad, 2013-04-30 15:13:16]

So we are officially OK with exposing Gr* in core headers?
I guess we only need a forward declare here...

[Justin Novosad, 2013-04-30 15:23:33]

New Patch.

[bsalomon, 2013-04-30 16:12:22]

On 2013/04/30 15:23:33, junov wrote:
> New Patch.

lgtm.

Yes, core files already include Gr headers and forward declare Gr types.

[reed1, 2013-04-30 16:17:45]

need comment in header, lgtm otherwise.

https://codereview.chromium.org/14646007/diff/5003/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/14646007/diff/5003/include/core/SkImage.h#new...
include/core/SkImage.h:73: uint32_t uniqueID() const { return fUniqueID; }
/**
 * Return a grtexture if the image is backed blah blah blah. Ownership rules
blah blah blah. Will return null for other image types blah balh.
 */

[Justin Novosad, 2013-05-01 22:38:20]

Committed patchset #4 manually as r8945 (presubmit successful).