Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: src/gpu/gl/GrGLGpu.cpp

Issue 1464593004: More tests for EGLImage (Closed) Base URL: https://skia.googlesource.com/skia.git@external
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/EGLImageTest.cpp » ('j') | tests/EGLImageTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLGpu.cpp
diff --git a/src/gpu/gl/GrGLGpu.cpp b/src/gpu/gl/GrGLGpu.cpp
index c07eafeae4aa6040e5555955fbe44e277e90c1a3..a200c24e6dfd3849e8d22f84ec6d3f31fbc0f31f 100644
--- a/src/gpu/gl/GrGLGpu.cpp
+++ b/src/gpu/gl/GrGLGpu.cpp
@@ -454,6 +454,11 @@ GrTexture* GrGLGpu::onWrapBackendTexture(const GrBackendTextureDesc& desc,
return nullptr;
}
}
+ // Sample count is interpretted to mean the number of samples that Gr code should allocate
joshualitt 2015/11/20 22:57:04 interpreted
bsalomon 2015/11/23 15:05:14 Done.
+ // for a render buffer that resolves to the texture. We don't support MSAA textures.
+ if (desc.fSampleCnt && !renderTarget) {
+ return nullptr;
+ }
switch (ownership) {
case kAdopt_GrWrapOwnership:
« no previous file with comments | « no previous file | tests/EGLImageTest.cpp » ('j') | tests/EGLImageTest.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698