More tests for EGLImage

Committed: https://skia.googlesource.com/skia/+/a98419be092cce2a7ef27a09b6fd8065ff709cff

[bsalomon, 2015-11-20 21:26:03]

Description was changed from

==========
update

BUG=skia:
==========

to

==========

==========

[bsalomon, 2015-11-20 21:26:04]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, joshualitt@google.com

[joshualitt, 2015-11-20 22:57:04]

https://codereview.chromium.org/1464593004/diff/100001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1464593004/diff/100001/src/gpu/gl/GrGLGpu.cpp...
src/gpu/gl/GrGLGpu.cpp:457: // Sample count is interpretted to mean the number
of samples that Gr code should allocate
interpreted

https://codereview.chromium.org/1464593004/diff/100001/tests/EGLImageTest.cpp
File tests/EGLImageTest.cpp (right):

https://codereview.chromium.org/1464593004/diff/100001/tests/EGLImageTest.cpp...
tests/EGLImageTest.cpp:201: externalDesc.fSampleCnt = 0;
is there a reason you set this to 0?

[bsalomon, 2015-11-23 14:38:24]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-11-23 14:38:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464593004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464593004/120001

[commit-bot: I haz the power, 2015-11-23 14:38:36]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-11-23 20:38 UTC

[bsalomon, 2015-11-23 15:05:14]

https://codereview.chromium.org/1464593004/diff/100001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1464593004/diff/100001/src/gpu/gl/GrGLGpu.cpp...
src/gpu/gl/GrGLGpu.cpp:457: // Sample count is interpretted to mean the number
of samples that Gr code should allocate
On 2015/11/20 22:57:04, joshualitt wrote:
> interpreted

Done.

https://codereview.chromium.org/1464593004/diff/100001/tests/EGLImageTest.cpp
File tests/EGLImageTest.cpp (right):

https://codereview.chromium.org/1464593004/diff/100001/tests/EGLImageTest.cpp...
tests/EGLImageTest.cpp:201: externalDesc.fSampleCnt = 0;
On 2015/11/20 22:57:04, joshualitt wrote:
> is there a reason you set this to 0?

Just in case someone added a third wrap test.

[egdaniel, 2015-11-23 15:08:23]

lgtm

[commit-bot: I haz the power, 2015-11-23 15:09:53]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/a98419be092cce2a7ef27a09b6fd8065ff709cff