Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1464593002: Various cleanups (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc
index e40887bbf0d4aab601a369c47f7874c572ee195c..6d4795751651e2f07d85452a2268b42be977d77b 100644
--- a/runtime/vm/flow_graph_compiler.cc
+++ b/runtime/vm/flow_graph_compiler.cc
@@ -103,8 +103,8 @@ static void PrecompilationModeHandler(bool value) {
// loading, deoptimization, ...). Noopt mode simulates behavior
// of precompiled code, therefore do not allow recompilation.
Compiler::set_allow_recompilation(false);
- // TODO(srdjan): Enable CHA deoptimization when eager class finalization is
- // implemented, either with precompilation or as a special pass.
+ // Precompilation finalizes all classes and thus allows CHA optimizations.
+ // Do not require CHA triggered deoptimization.
FLAG_use_cha_deopt = false;
// Calling the PrintStopMessage stub is not supported in precompiled code
// since it is done at places where no pool pointer is loaded.
@@ -546,11 +546,6 @@ void FlowGraphCompiler::VisitBlocks() {
#endif
}
- if (inline_id_to_function_.length() > max_inlining_id + 1) {
- // TODO(srdjan): Some inlined function can disappear,
- // truncate 'inline_id_to_function_'.
- }
-
if (is_optimizing()) {
LogBlock lb;
intervals.Add(IntervalStruct(prev_offset, prev_inlining_id));
« no previous file with comments | « no previous file | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698