Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1464583004:
Prepare switching arm cross-compile to ninja. (Closed)
|
Created:
5 years, 1 month ago by Michael Achenbach Modified:
5 years ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionPrepare switching arm cross-compile to ninja.
BUG=chromium:534332
LOG=n
TBR=jochen@chromium.org
NOTREECHECKS=true
Committed: https://crrev.com/321c4ace97d0398807e6c166e8300e0255a6e622
Cr-Commit-Position: refs/heads/master@{#32133}
Patch Set 1 #
Total comments: 5
Messages
Total messages: 25 (10 generated)
Description was changed from ========== Prepare switching arm cross-compile to ninja. BUG= ========== to ========== Prepare switching arm cross-compile to ninja. BUG=chromium:534332 LOG=n ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, kjellander@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464583004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Prepare switching arm cross-compile to ninja. BUG=chromium:534332 LOG=n ========== to ========== Prepare switching arm cross-compile to ninja. BUG=chromium:534332 LOG=n TBR=jochen@chromium.org ==========
TBR
lgtm with question https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi#newco... build/standalone.gypi:1218: ['OS=="linux" and target_arch=="arm" and host_arch!="arm" and clang==0', { I'm just curious: is host_arch ever arm?
https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi#newco... build/standalone.gypi:1218: ['OS=="linux" and target_arch=="arm" and host_arch!="arm" and clang==0', { On 2015/11/20 08:23:47, kjellander (chromium) wrote: > I'm just curious: is host_arch ever arm? Guess not. But can't hurt to check. This is a brain-off copy from common.gypi: https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...
On 2015/11/20 08:26:02, Michael Achenbach wrote: > https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi > File build/standalone.gypi (right): > > https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi#newco... > build/standalone.gypi:1218: ['OS=="linux" and target_arch=="arm" and > host_arch!="arm" and clang==0', { > On 2015/11/20 08:23:47, kjellander (chromium) wrote: > > I'm just curious: is host_arch ever arm? > > Guess not. But can't hurt to check. This is a brain-off copy from common.gypi: > https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&... Link was off by a few lines by now... https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464583004/1
Description was changed from ========== Prepare switching arm cross-compile to ninja. BUG=chromium:534332 LOG=n TBR=jochen@chromium.org ========== to ========== Prepare switching arm cross-compile to ninja. BUG=chromium:534332 LOG=n TBR=jochen@chromium.org NOTREECHECKS=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464583004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/321c4ace97d0398807e6c166e8300e0255a6e622 Cr-Commit-Position: refs/heads/master@{#32133}
Message was sent while issue was closed.
https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi#newco... build/standalone.gypi:1218: ['OS=="linux" and target_arch=="arm" and host_arch!="arm" and clang==0', { On 2015/11/20 08:23:47, kjellander (chromium) wrote: > I'm just curious: is host_arch ever arm? Drive-by answer: yes, we support native compilation on ARM machines.
Message was sent while issue was closed.
martyn.capewell@arm.com changed reviewers: + martyn.capewell@arm.com
Message was sent while issue was closed.
https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi#newco... build/standalone.gypi:1222: ['CC', '<!(which arm-linux-gnueabihf-gcc)'], Does this work if arm-linux-gnueabihf-gcc isn't already in your path? I set CC externally, but get failures on this which command.
Message was sent while issue was closed.
https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1464583004/diff/1/build/standalone.gypi#newco... build/standalone.gypi:1222: ['CC', '<!(which arm-linux-gnueabihf-gcc)'], On 2015/11/24 11:56:55, martyn.capewell wrote: > Does this work if arm-linux-gnueabihf-gcc isn't already in your path? I set CC > externally, but get failures on this which command. Hmm, that's not smart of gyp then. I thought it might keep an externally set CC. Do you use make or ninja? If you use make, we could add "<(GENERATOR)"=="ninja" to the conditions as a work-around.
Message was sent while issue was closed.
On 2015/11/24 12:27:31, Michael Achenbach wrote: > Do you use make or ninja? If you use make, we could add "<(GENERATOR)"=="ninja" > to the conditions as a work-around. I'm using make, via tools/cross_build_gcc.sh, and currently working around it using dummy arm-linux-gnueabihf-gcc executable files to make the 'which' work. The external CC is available to gyp after this point, it's just the 'which' exiting with status 1 (command not found) when there's no tools in the path already that causes a failure. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
