Issue 1464543002: Remove unsigned < signed comparison.

Issue 1464543002: Remove unsigned < signed comparison. (Closed)

Created:
5 years, 1 month ago by mtklein_C

Modified:
5 years, 1 month ago

Reviewers:
bsalomon, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Remove unsigned < signed comparison. This triggers -Wsign-compare on some builds. Not sure why none of those builds have -Werror set. BUG=skia:4561 Committed: https://skia.googlesource.com/skia/+/1d02a60fec20018c987ef827abbd5e77562c3a67

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/gpu/GrTypes.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 12 (6 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464543002/1

5 years, 1 month ago (2015-11-19 17:29:50 UTC) #6

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 1 month ago (2015-11-19 17:44:50 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464543002/1

5 years, 1 month ago (2015-11-19 17:52:46 UTC) #11

commit-bot: I haz the power

5 years, 1 month ago (2015-11-19 17:53:24 UTC) #12

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1d02a60fec20018c987ef827abbd5e77562c3a67

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages