win: Don't duplicate handles in handle restriction list

client/crashpad_client_win_test.cc

+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "client/crashpad_client.h"
+
+#include "base/files/file_path.h"
+#include "gtest/gtest.h"
+#include "test/paths.h"
+#include "test/scoped_temp_dir.h"
+
+namespace crashpad {
+namespace test {
+namespace {
+
+TEST(CrashpadClient, StartWithInvalidHandles) {

[Mark Mentovai, 2015/11/19 19:00:19]

…that argues for these being out-of-process tests.

+  HANDLE original_stdout = GetStdHandle(STD_OUTPUT_HANDLE);
+  HANDLE original_stderr = GetStdHandle(STD_ERROR_HANDLE);
+  SetStdHandle(STD_OUTPUT_HANDLE, INVALID_HANDLE_VALUE);
+  SetStdHandle(STD_ERROR_HANDLE, INVALID_HANDLE_VALUE);
+
+  ScopedTempDir temp_dir;
+  base::FilePath handler_path = Paths::Executable().DirName().Append(
+      FILE_PATH_LITERAL("crashpad_handler.exe"));
+  CrashpadClient client;
+  ASSERT_TRUE(client.StartHandler(handler_path,
+                                  temp_dir.path(),
+                                  "",
+                                  std::map<std::string, std::string>(),
+                                  std::vector<std::string>(),
+                                  false));
+  EXPECT_TRUE(client.UseHandler());
+
+  SetStdHandle(STD_OUTPUT_HANDLE, original_stdout);
+  SetStdHandle(STD_ERROR_HANDLE, original_stderr);
+}
+
+TEST(CrashpadClient, StartWithSameStdoutStderr) {
+  HANDLE original_stdout = GetStdHandle(STD_OUTPUT_HANDLE);
+  HANDLE original_stderr = GetStdHandle(STD_ERROR_HANDLE);
+  SetStdHandle(STD_OUTPUT_HANDLE, original_stderr);
+
+  ScopedTempDir temp_dir;
+  base::FilePath handler_path = Paths::Executable().DirName().Append(
+      FILE_PATH_LITERAL("crashpad_handler.exe"));
+  CrashpadClient client;
+  ASSERT_TRUE(client.StartHandler(handler_path,
+                                  temp_dir.path(),
+                                  "",
+                                  std::map<std::string, std::string>(),
+                                  std::vector<std::string>(),
+                                  false));
+  EXPECT_TRUE(client.UseHandler());
+
+  SetStdHandle(STD_OUTPUT_HANDLE, original_stdout);
+}
+
+}  // namespace
+}  // namespace test
+}  // namespace crashpad