Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issue 1464463003: Reduce the number of worker threads GN uses. (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce the number of worker threads GN uses. I noticed the main thread is being starved which slows down execution. On a Z620 using the new default improves generation speed for Chrome by 20%. This also adds trace events for the OnResolved step of target resolution which is a bottleneck in some cases. Committed: https://crrev.com/d0f8e7b23cd48a8e4685e82b7beffb0930554bba Cr-Commit-Position: refs/heads/master@{#360955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M tools/gn/scheduler.cc View 1 chunk +37 lines, -3 lines 0 comments Download
M tools/gn/target.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/gn/trace.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/trace.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
brettw
5 years, 1 month ago (2015-11-19 21:34:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464463003/1
5 years, 1 month ago (2015-11-19 21:38:47 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
5 years, 1 month ago (2015-11-19 23:45:41 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464463003/1
5 years, 1 month ago (2015-11-20 00:06:36 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-20 00:39:40 UTC) #10
cpu_(ooo_6.6-7.5)
lgtm
5 years, 1 month ago (2015-11-20 22:25:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464463003/1
5 years, 1 month ago (2015-11-20 23:05:28 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 23:52:43 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 23:53:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0f8e7b23cd48a8e4685e82b7beffb0930554bba
Cr-Commit-Position: refs/heads/master@{#360955}

Powered by Google App Engine
This is Rietveld 408576698