Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

Issue 1464443002: bluetooth: android: Add BluetoothDevice::ConnectErrorCode enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: VI Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
diff --git a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
index f8d4d8c0e7cb45838448359ee0ca06658254a004..9f237eacf4bdba96e6ec1e933795bd138a49c0a9 100644
--- a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
+++ b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
@@ -1147,8 +1147,10 @@ IN_PROC_BROWSER_TEST_F(BluetoothLowEnergyApiTest, GattConnection) {
.WillRepeatedly(Return(device0_.get()));
EXPECT_CALL(*mock_adapter_, GetDevice(kTestLeDeviceAddress1))
.WillRepeatedly(Return(device1_.get()));
+ static_assert(BluetoothDevice::NUM_CONNECT_ERROR_CODES == 15,
+ "Update required if the number of BluetoothDevice enums changes.");
EXPECT_CALL(*device0_, CreateGattConnection(_, _))
- .Times(9)
+ .Times(16)
.WillOnce(InvokeCallbackArgument<1>(BluetoothDevice::ERROR_FAILED))
.WillOnce(InvokeCallbackArgument<1>(BluetoothDevice::ERROR_INPROGRESS))
.WillOnce(InvokeCallbackArgument<1>(BluetoothDevice::ERROR_AUTH_FAILED))
@@ -1157,6 +1159,20 @@ IN_PROC_BROWSER_TEST_F(BluetoothLowEnergyApiTest, GattConnection) {
.WillOnce(InvokeCallbackArgument<1>(BluetoothDevice::ERROR_AUTH_TIMEOUT))
.WillOnce(
InvokeCallbackArgument<1>(BluetoothDevice::ERROR_UNSUPPORTED_DEVICE))
+ .WillOnce(InvokeCallbackArgument<1>(
+ BluetoothDevice::ERROR_ATTRIBUTE_LENGTH_INVALID))
+ .WillOnce(InvokeCallbackArgument<1>(
+ BluetoothDevice::ERROR_CONNECTION_CONGESTED))
+ .WillOnce(InvokeCallbackArgument<1>(
+ BluetoothDevice::ERROR_INSUFFICIENT_ENCRYPTION))
+ .WillOnce(
+ InvokeCallbackArgument<1>(BluetoothDevice::ERROR_OFFSET_INVALID))
+ .WillOnce(InvokeCallbackArgument<1>(
+ BluetoothDevice::ERROR_READ_NOT_PERMITTED))
+ .WillOnce(InvokeCallbackArgument<1>(
+ BluetoothDevice::ERROR_REQUEST_NOT_SUPPORTED))
+ .WillOnce(InvokeCallbackArgument<1>(
+ BluetoothDevice::ERROR_WRITE_NOT_PERMITTED))
.WillOnce(InvokeCallbackWithScopedPtrArg<0, BluetoothGattConnection>(
CreateGattConnection(mock_adapter_, kTestLeDeviceAddress0,
true /* expect_disconnect */)))

Powered by Google App Engine
This is Rietveld 408576698