content/browser/bluetooth/bluetooth_metrics.h - Issue 1464443002: bluetooth: android: Add BluetoothDevice::ConnectErrorCode enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/bluetooth/bluetooth_metrics.h

Issue 1464443002: bluetooth: android: Add BluetoothDevice::ConnectErrorCode enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: II Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/bluetooth/bluetooth_metrics.h

diff --git a/content/browser/bluetooth/bluetooth_metrics.h b/content/browser/bluetooth/bluetooth_metrics.h

index 87cd83c607228d685636eeee1ce5405ce82f131f..ee06b5950d1b39a0c64eea7c3870c8eb12afc8a2 100644

--- a/content/browser/bluetooth/bluetooth_metrics.h

+++ b/content/browser/bluetooth/bluetooth_metrics.h

@@ -95,9 +95,13 @@ enum class UMAConnectGATTOutcome {

AUTH_REJECTED = 7,

AUTH_TIMEOUT = 8,

UNSUPPORTED_DEVICE = 9,

- // Note: Add new ConnectGATT outcomes immediately above this line. Make sure

- // to update the enum list in tools/metrics/histograms/histograms.xml

- // accordingly.

+ ATTRIBUTE_LENGTH_INVALID = 10,

+ CONNECTION_CONGESTED = 11,

+ INSUFFICIENT_ENCRYPTION = 12,

+ OFFSET_INVALID = 13,

+ READ_FAILED = 14,

+ REQUEST_NOT_SUPPORTED = 15,

+ WRITE_FAILED= 16,

COUNT

scheib 2015/11/24 01:30:48 Preserve the comment above COUNT.

Kai Jiang 2015/11/25 14:17:13 Done.

};

// There should be a call to this function before every

« no previous file with comments | « content/browser/bluetooth/bluetooth_dispatcher_host.cc ('k') | device/bluetooth/bluetooth_device.h » ('j') | device/bluetooth/bluetooth_device.h » ('J')