bluetooth: android: Add BluetoothDevice::ConnectErrorCode enums

chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Enumeration of possible states during pairing.  The value associated with
  * each state maps to a localized string in the global variable
  * |loadTimeData|.
  * @enum {string}
  */
@@ skipping 503 matching lines @@
     var message;
     if (chrome.runtime.lastError) {
       var errorMessage = chrome.runtime.lastError.message;
       if (errorMessage != 'Connect failed') {
         console.error('bluetoothPrivate.connect: Unexpected error for: ' +
                       address + ': ' + errorMessage);
       }
     }
     switch (result) {
       case chrome.bluetoothPrivate.ConnectResultType.SUCCESS:
       case chrome.bluetoothPrivate.ConnectResultType.ALREADY_CONNECTED:

[scheib, 2015/11/26 00:02:51]

Sort list alphabetically. 

[Kai Jiang, 2015/11/29 10:40:51]

Done.

         BluetoothPairing.dismissDialog();
         return;
       case chrome.bluetoothPrivate.ConnectResultType.UNKNOWN_ERROR:
         message = 'bluetoothConnectUnknownError';
         break;
       case chrome.bluetoothPrivate.ConnectResultType.IN_PROGRESS:
         message = 'bluetoothConnectInProgress';
         break;
       case chrome.bluetoothPrivate.ConnectResultType.FAILED:
         message = 'bluetoothConnectFailed';
         break;
       case chrome.bluetoothPrivate.ConnectResultType.AUTH_FAILED:
         message = 'bluetoothConnectAuthFailed';
         break;
       case chrome.bluetoothPrivate.ConnectResultType.AUTH_CANCELED:
         message = 'bluetoothConnectAuthCanceled';
         break;
       case chrome.bluetoothPrivate.ConnectResultType.AUTH_REJECTED:
         message = 'bluetoothConnectAuthRejected';
         break;
       case chrome.bluetoothPrivate.ConnectResultType.AUTH_TIMEOUT:
         message = 'bluetoothConnectAuthTimeout';
         break;
       case chrome.bluetoothPrivate.ConnectResultType.UNSUPPORTED_DEVICE:
         message = 'bluetoothConnectUnsupportedDevice';
         break;
+      case chrome.bluetoothPrivate.ConnectResultType.ATTRIBUTE_LENGTH_INVALID:

[scheib, 2015/11/26 00:02:51]

We should check with [OWNERS] of this UI and propose that we only use assert()
here, and NOT add strings. We don't expect these errors on chromeOS code. So,
the API's .idl must include the values, but we can assert here that on ChromeOS
we do not encounter them. 

[OWNERS]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

I will add an owner in next message.

+        message = 'bluetoothConnectAttributeLengthInvalid';
+        break;
+      case chrome.bluetoothPrivate.ConnectResultType.CONNECTION_CONGESTED:
+        message = 'bluetoothConnectConnectionCongested';
+        break;
+      case chrome.bluetoothPrivate.ConnctResultType.INSUFFICIENT_ENCRYPTION:
+        message = 'bluetoothConnectInsufficientEncryption';
+        break;
+      case chrome.bluetoothPrivate.ConnctResultType.OFFSET_INVALID:
+        message = 'bluetoothConnectOffsetInvalid';
+        break;
+      case chrome.bluetoothPrivate.ConnctResultType.READ_FAILED:
+        message = 'bluetoothConnectReadFailed';

[scheib, 2015/11/26 00:02:51]

Enum and string should use 'permitted' instead of 'failed'.

+        break;
+      case chrome.bluetoothPrivate.ConnctResultType.REQUEST_NOT_SUPPORTED:
+        message = 'bluetoothConnectRequestNotSupported';
+        break;
+      case chrome.bluetoothPrivate.ConnctResultType.WRITE_FAILED:
+        message = 'bluetoothConnectWriteFailed';

[scheib, 2015/11/26 00:02:51]

Enum and string should use 'permitted' instead of 'failed'.

[Kai Jiang, 2015/11/29 10:40:51]

Done.

+        break;
     }
     if (message)
       BluetoothPairing.showMessage({message: message, address: address});
   };
 
   /**
    * Closes the Bluetooth pairing dialog.
    */
   BluetoothPairing.dismissDialog = function() {
     var overlay = PageManager.getTopmostVisiblePage();
     var dialog = BluetoothPairing.getInstance();
     if (overlay == dialog && dialog.dismissible_) {
       if (dialog.event_)
         dialog.event_.pairing = BluetoothPairingEventType.DISMISSED;
       PageManager.closeOverlay();
     }
   };
 
   // Export
   return {
     BluetoothPairing: BluetoothPairing
   };
 });