Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1464413002: reland 1: Add basic memory usage tests for attachment brokering. (Closed)

Created:
5 years, 1 month ago by erikchen
Modified:
5 years ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reland 1: Add basic memory usage tests for attachment brokering. One of the assumptions of the newly added tests was violated under a sanitizer build. This is not particularly surprising, so I disabled that check for sanitizer builds. > I added two tests for memory leaks in the attachment brokering process. The > first checks memory usage after brokering a single, large, shared memory object. > The second checks memory usage after brokering a thousand, smaller memory > objects. > > BUG=557387 > Committed: https://crrev.com/a519e56d03e1f6d69b7475bdd006f5e47b4f581e > Cr-Commit-Position: refs/heads/master@{#360935} BUG=557387 Committed: https://crrev.com/e50acd8893ed6898bc5767ae6fd9859493be3a0d Cr-Commit-Position: refs/heads/master@{#361391}

Patch Set 1 : Original CL. #

Patch Set 2 : Disable some checks on sanitizer builds. #

Patch Set 3 : Update comment. #

Patch Set 4 : Comments from tsepez. #

Patch Set 5 : Compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -3 lines) Patch
M ipc/attachment_broker_mac_unittest.cc View 1 2 3 4 9 chunks +180 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
erikchen
tsepez: Please review. Diff patch set 3 against patch set 1 to see changes from ...
5 years, 1 month ago (2015-11-23 19:16:31 UTC) #2
Tom Sepez
Howabout just changing the shm read to a write? That would avoid the uninit warning.
5 years, 1 month ago (2015-11-23 20:28:20 UTC) #3
erikchen
On 2015/11/23 20:28:20, Tom Sepez wrote: > Howabout just changing the shm read to a ...
5 years, 1 month ago (2015-11-23 22:16:50 UTC) #4
Tom Sepez
lgtm
5 years ago (2015-11-24 17:13:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464413002/80001
5 years ago (2015-11-24 18:03:44 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-11-24 18:29:05 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-24 18:29:53 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e50acd8893ed6898bc5767ae6fd9859493be3a0d
Cr-Commit-Position: refs/heads/master@{#361391}

Powered by Google App Engine
This is Rietveld 408576698