Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1464383002: Don't load WebUI if provisional navigation is for non-chrome URL (Closed)

Created:
5 years, 1 month ago by Jackie Quinn
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't load WebUI if provisional navigation is for non-chrome URL Putative fix for crbug.com/545479. If WebUIManager is created but navigation occurs before the WebUI URL starts loading, provisional navigation for a non-WebUI URL could be observed by WebUIManager, and WebUI should not be loaded in that case. BUG=545479 Committed: https://crrev.com/3b976a68ca956118270259a173ea9a8806794424 Cr-Commit-Position: refs/heads/master@{#361143}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ios/web/webui/crw_web_ui_manager.mm View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
Jackie Quinn
5 years, 1 month ago (2015-11-23 17:16:09 UTC) #2
Eugene But (OOO till 7-30)
https://codereview.chromium.org/1464383002/diff/1/ios/web/webui/crw_web_ui_manager.mm File ios/web/webui/crw_web_ui_manager.mm (right): https://codereview.chromium.org/1464383002/diff/1/ios/web/webui/crw_web_ui_manager.mm#newcode91 ios/web/webui/crw_web_ui_manager.mm:91: // If URL is not an application specific URL, ...
5 years, 1 month ago (2015-11-23 17:31:42 UTC) #3
Eugene But (OOO till 7-30)
lgtm
5 years, 1 month ago (2015-11-23 17:45:14 UTC) #4
Jackie Quinn
On 2015/11/23 17:31:42, eugenebut wrote: > https://codereview.chromium.org/1464383002/diff/1/ios/web/webui/crw_web_ui_manager.mm > File ios/web/webui/crw_web_ui_manager.mm (right): > > https://codereview.chromium.org/1464383002/diff/1/ios/web/webui/crw_web_ui_manager.mm#newcode91 > ...
5 years, 1 month ago (2015-11-23 17:48:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464383002/1
5 years, 1 month ago (2015-11-23 17:51:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 18:17:42 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 18:18:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b976a68ca956118270259a173ea9a8806794424
Cr-Commit-Position: refs/heads/master@{#361143}

Powered by Google App Engine
This is Rietveld 408576698