Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1464363002: Provider API for SSOResources (Closed)

Created:
5 years ago by sdefresne
Modified:
5 years ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provider API for SSOResources BUG=475439 Review URL: https://chromereviews.googleplex.com/203517013 Committed: https://crrev.com/866650bc20c8d5865dcb7179e5cf9811e2cf01c2 Cr-Commit-Position: refs/heads/master@{#361625}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove duplicate declaration of GetSigninResourcesProvider() method #

Patch Set 3 : Remove duplicate implementation of GetSigninResourcesProvider method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M ios/provider/ios_provider_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/signin/signin_resources_provider.h View 1 chunk +41 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/signin/signin_resources_provider.mm View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sdefresne
Please take a look.
5 years ago (2015-11-23 15:27:26 UTC) #2
droger
https://codereview.chromium.org/1464363002/diff/1/ios/public/provider/chrome/browser/chrome_browser_provider.h File ios/public/provider/chrome/browser/chrome_browser_provider.h (right): https://codereview.chromium.org/1464363002/diff/1/ios/public/provider/chrome/browser/chrome_browser_provider.h#newcode112 ios/public/provider/chrome/browser/chrome_browser_provider.h:112: virtual SigninResourcesProvider* GetSigninResourcesProvider(); This is already declared above.
5 years ago (2015-11-23 16:45:12 UTC) #3
sdefresne
ptal https://codereview.chromium.org/1464363002/diff/1/ios/public/provider/chrome/browser/chrome_browser_provider.h File ios/public/provider/chrome/browser/chrome_browser_provider.h (right): https://codereview.chromium.org/1464363002/diff/1/ios/public/provider/chrome/browser/chrome_browser_provider.h#newcode112 ios/public/provider/chrome/browser/chrome_browser_provider.h:112: virtual SigninResourcesProvider* GetSigninResourcesProvider(); On 2015/11/23 at 16:45:12, droger ...
5 years ago (2015-11-23 17:00:20 UTC) #4
droger
Same issue in the .cc file. LGTM once fixed.
5 years ago (2015-11-23 17:05:57 UTC) #5
sdefresne
On 2015/11/23 at 17:05:57, droger wrote: > Same issue in the .cc file. > > ...
5 years ago (2015-11-23 17:17:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464363002/40001
5 years ago (2015-11-25 10:47:50 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-25 11:30:49 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 11:31:56 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/866650bc20c8d5865dcb7179e5cf9811e2cf01c2
Cr-Commit-Position: refs/heads/master@{#361625}

Powered by Google App Engine
This is Rietveld 408576698