Fix strict mode violation on document mode initialization.

Fix strict mode violation on document mode initialization.

Loading shared prefs requires an async disk access. If it
doesn't finish in time, it can cause the UI thread to block,
violating strict mode. This patch pre-loads the document-mode
shared prefs, as we already do for the main Chrome default
shared prefs, to ensure that it's ready before we need it.

BUG=543201
Committed: https://crrev.com/f70d99783581291fcac5c603c7862d360caa7b3d
Cr-Commit-Position: refs/heads/master@{#362031}

[hartmanng, 2015-11-26 21:51:03]

Description was changed from

==========
Fix strict mode violation on document mode initialization.

Loading shared prefs requires an async disk access. If it
doesn't finish in time, it can cause the UI thread to block,
violating strict mode. This patch pre-loads the document-mode
shared prefs, as we already do for the main Chrome default
shared prefs, to ensure that it's ready before we need it.

BUG=543201
==========

to

==========
Fix strict mode violation on document mode initialization.

Loading shared prefs requires an async disk access. If it
doesn't finish in time, it can cause the UI thread to block,
violating strict mode. This patch pre-loads the document-mode
shared prefs, as we already do for the main Chrome default
shared prefs, to ensure that it's ready before we need it.

BUG=543201
==========

[hartmanng, 2015-11-26 21:51:04]

hartmanng@chromium.org changed reviewers:
+ dtrainor@chromium.org

[hartmanng, 2015-11-26 21:51:13]

David, please take a look.

https://codereview.chromium.org/1464313010/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java
(right):

https://codereview.chromium.org/1464313010/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java:142:
public static void warmUpSharedPrefs(Context context) {
As an alternative to the public static method here, we could just call

mApplication.getSharedPreferences(DocumentTabModelImpl.PREF_PACKAGE,
Context.MODE_PRIVATE);

from ChromeBrowserInitializer.warmUpSharedPrefs(), and remove the
@VisibleForTesting annotation from PREF_PACKAGE.

[David Trainor- moved to gerrit, 2015-11-27 16:17:51]

lgtm

[hartmanng, 2015-11-27 16:19:28]

The CQ bit was checked by hartmanng@chromium.org

[hartmanng, 2015-11-27 16:19:38]

Thanks!

[commit-bot: I haz the power, 2015-11-27 16:20:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464313010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464313010/1

[commit-bot: I haz the power, 2015-11-27 18:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 18:05:56]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[hartmanng, 2015-11-27 18:26:02]

The CQ bit was checked by hartmanng@chromium.org

[commit-bot: I haz the power, 2015-11-27 18:26:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464313010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464313010/1

[commit-bot: I haz the power, 2015-11-27 19:20:37]

Description was changed from

==========
Fix strict mode violation on document mode initialization.

Loading shared prefs requires an async disk access. If it
doesn't finish in time, it can cause the UI thread to block,
violating strict mode. This patch pre-loads the document-mode
shared prefs, as we already do for the main Chrome default
shared prefs, to ensure that it's ready before we need it.

BUG=543201
==========

to

==========
Fix strict mode violation on document mode initialization.

Loading shared prefs requires an async disk access. If it
doesn't finish in time, it can cause the UI thread to block,
violating strict mode. This patch pre-loads the document-mode
shared prefs, as we already do for the main Chrome default
shared prefs, to ensure that it's ready before we need it.

BUG=543201
==========

[commit-bot: I haz the power, 2015-11-27 19:20:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-27 19:21:17]

Description was changed from

==========
Fix strict mode violation on document mode initialization.

Loading shared prefs requires an async disk access. If it
doesn't finish in time, it can cause the UI thread to block,
violating strict mode. This patch pre-loads the document-mode
shared prefs, as we already do for the main Chrome default
shared prefs, to ensure that it's ready before we need it.

BUG=543201
==========

to

==========
Fix strict mode violation on document mode initialization.

Loading shared prefs requires an async disk access. If it
doesn't finish in time, it can cause the UI thread to block,
violating strict mode. This patch pre-loads the document-mode
shared prefs, as we already do for the main Chrome default
shared prefs, to ensure that it's ready before we need it.

BUG=543201

Committed: https://crrev.com/f70d99783581291fcac5c603c7862d360caa7b3d
Cr-Commit-Position: refs/heads/master@{#362031}
==========

[commit-bot: I haz the power, 2015-11-27 19:21:18]

Patchset 1 (id:??) landed as
https://crrev.com/f70d99783581291fcac5c603c7862d360caa7b3d
Cr-Commit-Position: refs/heads/master@{#362031}