Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: src/objects-inl.h

Issue 1464313009: Remove leftover NoIncrementalWriteBarrier prototypes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/transitions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 2567 matching lines...) Expand 10 before | Expand all | Expand 10 after
2578 Object* value, 2578 Object* value,
2579 WriteBarrierMode mode) { 2579 WriteBarrierMode mode) {
2580 DCHECK(map() != GetHeap()->fixed_cow_array_map()); 2580 DCHECK(map() != GetHeap()->fixed_cow_array_map());
2581 DCHECK(index >= 0 && index < this->length()); 2581 DCHECK(index >= 0 && index < this->length());
2582 int offset = kHeaderSize + index * kPointerSize; 2582 int offset = kHeaderSize + index * kPointerSize;
2583 WRITE_FIELD(this, offset, value); 2583 WRITE_FIELD(this, offset, value);
2584 CONDITIONAL_WRITE_BARRIER(GetHeap(), this, offset, value, mode); 2584 CONDITIONAL_WRITE_BARRIER(GetHeap(), this, offset, value, mode);
2585 } 2585 }
2586 2586
2587 2587
2588 void FixedArray::NoIncrementalWriteBarrierSet(FixedArray* array,
2589 int index,
2590 Object* value) {
2591 DCHECK(array->map() != array->GetHeap()->fixed_cow_array_map());
2592 DCHECK(index >= 0 && index < array->length());
2593 int offset = kHeaderSize + index * kPointerSize;
2594 WRITE_FIELD(array, offset, value);
2595 Heap* heap = array->GetHeap();
2596 if (heap->InNewSpace(value)) {
2597 heap->RecordWrite(array->address(), offset);
2598 }
2599 }
2600
2601
2602 void FixedArray::NoWriteBarrierSet(FixedArray* array, 2588 void FixedArray::NoWriteBarrierSet(FixedArray* array,
2603 int index, 2589 int index,
2604 Object* value) { 2590 Object* value) {
2605 DCHECK(array->map() != array->GetHeap()->fixed_cow_array_map()); 2591 DCHECK(array->map() != array->GetHeap()->fixed_cow_array_map());
2606 DCHECK(index >= 0 && index < array->length()); 2592 DCHECK(index >= 0 && index < array->length());
2607 DCHECK(!array->GetHeap()->InNewSpace(value)); 2593 DCHECK(!array->GetHeap()->InNewSpace(value));
2608 WRITE_FIELD(array, kHeaderSize + index * kPointerSize, value); 2594 WRITE_FIELD(array, kHeaderSize + index * kPointerSize, value);
2609 } 2595 }
2610 2596
2611 2597
(...skipping 5258 matching lines...) Expand 10 before | Expand all | Expand 10 after
7870 #undef WRITE_INT64_FIELD 7856 #undef WRITE_INT64_FIELD
7871 #undef READ_BYTE_FIELD 7857 #undef READ_BYTE_FIELD
7872 #undef WRITE_BYTE_FIELD 7858 #undef WRITE_BYTE_FIELD
7873 #undef NOBARRIER_READ_BYTE_FIELD 7859 #undef NOBARRIER_READ_BYTE_FIELD
7874 #undef NOBARRIER_WRITE_BYTE_FIELD 7860 #undef NOBARRIER_WRITE_BYTE_FIELD
7875 7861
7876 } // namespace internal 7862 } // namespace internal
7877 } // namespace v8 7863 } // namespace v8
7878 7864
7879 #endif // V8_OBJECTS_INL_H_ 7865 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/transitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698