MediaRecorder testing of resume functionality and more start tests

MediaRecorder testing of resume functionality and more start tests

BUG=chromium:548914
Committed: https://crrev.com/3f39c25b888f3ccfb9a18e7d31ee20f0bcf89c58
Cr-Commit-Position: refs/heads/master@{#362288}

[cpaulin (no longer in chrome), 2015-11-25 22:41:48]

Description was changed from

==========
MediaRecorder testing of resume functionality and more start tests

BUG=chromium:548914
==========

to

==========
MediaRecorder testing of resume functionality and more start tests

BUG=chromium:548914
==========

[cpaulin (no longer in chrome), 2015-11-25 22:41:48]

cpaulin@chromium.org changed reviewers:
+ phoglund@chromium.org

[cpaulin (no longer in chrome), 2015-11-30 18:23:16]

New CL ready for review

[phoglund_chromium, 2015-11-30 20:42:56]

lgtm

https://codereview.chromium.org/1464313008/diff/1/content/test/data/media/med...
File content/test/data/media/mediarecorder_test.html (right):

https://codereview.chromium.org/1464313008/diff/1/content/test/data/media/med...
content/test/data/media/mediarecorder_test.html:194: theRecorder.onstart =
function(event) {
While I think this is fine, it would have been cool if the media recorder
returned promises. Then you could just do theRecorder.start().then(...)

https://codereview.chromium.org/1464313008/diff/1/content/test/data/media/med...
content/test/data/media/mediarecorder_test.html:202: return waitFor('Make sure
the start event was received',
I realized I actually had to read up a bit to understand this, even though I've
seen it in your previous patch. So when a .then returns a value, it gets passed
on to the next then, except if it's a promise, in which case it gets worked into
the chain.

[cpaulin (no longer in chrome), 2015-11-30 21:05:56]

The CQ bit was checked by cpaulin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 21:08:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464313008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464313008/1

[commit-bot: I haz the power, 2015-11-30 23:45:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 23:45:57]

Dry run: This issue passed the CQ dry run.

[cpaulin (no longer in chrome), 2015-11-30 23:49:41]

The CQ bit was checked by cpaulin@chromium.org

[commit-bot: I haz the power, 2015-11-30 23:50:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464313008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464313008/1

[commit-bot: I haz the power, 2015-12-01 00:14:29]

Description was changed from

==========
MediaRecorder testing of resume functionality and more start tests

BUG=chromium:548914
==========

to

==========
MediaRecorder testing of resume functionality and more start tests

BUG=chromium:548914
==========

[commit-bot: I haz the power, 2015-12-01 00:14:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-01 00:15:26]

Description was changed from

==========
MediaRecorder testing of resume functionality and more start tests

BUG=chromium:548914
==========

to

==========
MediaRecorder testing of resume functionality and more start tests

BUG=chromium:548914

Committed: https://crrev.com/3f39c25b888f3ccfb9a18e7d31ee20f0bcf89c58
Cr-Commit-Position: refs/heads/master@{#362288}
==========

[commit-bot: I haz the power, 2015-12-01 00:15:26]

Patchset 1 (id:??) landed as
https://crrev.com/3f39c25b888f3ccfb9a18e7d31ee20f0bcf89c58
Cr-Commit-Position: refs/heads/master@{#362288}

[cpaulin (no longer in chrome), 2015-12-02 00:05:54]

closing drafts

https://codereview.chromium.org/1464313008/diff/1/content/test/data/media/med...
File content/test/data/media/mediarecorder_test.html (right):

https://codereview.chromium.org/1464313008/diff/1/content/test/data/media/med...
content/test/data/media/mediarecorder_test.html:194: theRecorder.onstart =
function(event) {
On 2015/11/30 20:42:56, phoglund_chrome wrote:
> While I think this is fine, it would have been cool if the media recorder
> returned promises. Then you could just do theRecorder.start().then(...)

Acknowledged.

https://codereview.chromium.org/1464313008/diff/1/content/test/data/media/med...
content/test/data/media/mediarecorder_test.html:202: return waitFor('Make sure
the start event was received',
On 2015/11/30 20:42:56, phoglund_chrome wrote:
> I realized I actually had to read up a bit to understand this, even though
I've
> seen it in your previous patch. So when a .then returns a value, it gets
passed
> on to the next then, except if it's a promise, in which case it gets worked
into
> the chain.

Acknowledged.