cc/trees/compositor_mode.h - Issue 1464313007: cc: Introduce CompositorMode enum.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/trees/compositor_mode.h

Issue 1464313007: cc: Introduce CompositorMode enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_BASE_RESOURCE_ID_H_	5 #ifndef CC_TREES_COMPOSITOR_MODE_H_

6 #define CC_BASE_RESOURCE_ID_H_	6 #define CC_TREES_COMPOSITOR_MODE_H_

7

8 #include <stdint.h>

9	7

10 namespace cc {	8 namespace cc {

11	9

12 using ResourceId = uint32_t;	10 enum CompositorMode {

	11 SingleThreaded,

	12 Threaded,
	vmpstr 2015/12/07 18:50:09 I'm kind of wondering if this should be MultiThrea I'm kind of wondering if this should be MultiThreaded, but I guess this is consistent with CreateThreaded/CreateSingleThreaded. Can you leave a comment above the enum explaining where this is used and what this affects? Khushal 2015/12/07 21:49:26 Yup. Wanted to keep it consistent with the LayerTr Show quoted text On 2015/12/07 18:50:09, vmpstr wrote: > I'm kind of wondering if this should be MultiThreaded, but I guess this is > consistent with CreateThreaded/CreateSingleThreaded. > Yup. Wanted to keep it consistent with the LayerTreeHost Create methods. Show quoted text > Can you leave a comment above the enum explaining where this is used and what > this affects? Done.
	13 };

13	14

14 } // namespace cc	15 } // namespace cc

15	16

16 #endif // CC_BASE_RESOURCE_ID_H_	17 #endif // CC_TREES_COMPOSITOR_MODE_H_

OLD	NEW

« cc/test/layer_tree_test.cc ('K') | « cc/test/layer_tree_test.cc ('k') | cc/trees/layer_tree_host.h » ('j') | cc/trees/layer_tree_host.h » ('J')