Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1464313003: Revert of Start calling show/hide onStart/onStop in DocumentActivity (Closed)

Created:
5 years, 1 month ago by Yusuf
Modified:
5 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Start calling show/hide onStart/onStop in DocumentActivity (patchset #1 id:1 of https://codereview.chromium.org/1455343002/ ) Reason for revert: BUG=559197 This was causing an early tab.show call which made the test think the activity is in the foreground. Reverting my CL for now. Will have to figure out a proper way to hide/show to reland. Original issue's description: > Start calling show/hide onStart/onStop in DocumentActivity > > This logic in documents diverge from CHromeActivity behavior for > archaic reasons (crbug.com/451672). Making documents show/hide > in the same time as all other ChromeActivities with this change. > Verified that the previous bug that caused the bheavior divergence > no longer exists after this CL. > > BUG=546182 > > Committed: https://crrev.com/e548d4580bbd915716a855f9195b6f5f2d63d2a1 > Cr-Commit-Position: refs/heads/master@{#360581} TBR=dfalcantara@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546182 Committed: https://crrev.com/bc113d52b7f5fbf39123f4b43ea779ee2dd587c3 Cr-Commit-Position: refs/heads/master@{#361223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuf
Created Revert of Start calling show/hide onStart/onStop in DocumentActivity
5 years, 1 month ago (2015-11-24 00:05:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464313003/1
5 years, 1 month ago (2015-11-24 00:09:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-24 00:11:35 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 00:12:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc113d52b7f5fbf39123f4b43ea779ee2dd587c3
Cr-Commit-Position: refs/heads/master@{#361223}

Powered by Google App Engine
This is Rietveld 408576698