Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1464313002: Move //service/android to //service/java_handler (Closed)

Created:
5 years, 1 month ago by qsr
Modified:
5 years, 1 month ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -358 lines) Patch
M services/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D services/android/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D services/android/java/src/org/chromium/services/android/JavaHandler.java View 1 chunk +0 lines, -86 lines 0 comments Download
D services/android/java_handler.h View 1 chunk +0 lines, -54 lines 0 comments Download
D services/android/java_handler.cc View 1 chunk +0 lines, -164 lines 0 comments Download
A + services/java_handler/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
A + services/java_handler/java/src/org/chromium/services/java_handler/JavaHandler.java View 1 chunk +1 line, -1 line 0 comments Download
A + services/java_handler/java_handler.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + services/java_handler/java_handler.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/IntentReceiverRegistry.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qsr
5 years, 1 month ago (2015-11-23 09:58:34 UTC) #1
ppi
https://codereview.chromium.org/1464313002/diff/20001/services/BUILD.gn File services/BUILD.gn (right): https://codereview.chromium.org/1464313002/diff/20001/services/BUILD.gn#newcode30 services/BUILD.gn:30: "//services/java_handler", alphabetize https://codereview.chromium.org/1464313002/diff/20001/services/java_handler/java_handler.h File services/java_handler/java_handler.h (right): https://codereview.chromium.org/1464313002/diff/20001/services/java_handler/java_handler.h#newcode5 services/java_handler/java_handler.h:5: #ifndef ...
5 years, 1 month ago (2015-11-23 10:00:42 UTC) #2
qsr
https://codereview.chromium.org/1464313002/diff/20001/services/BUILD.gn File services/BUILD.gn (right): https://codereview.chromium.org/1464313002/diff/20001/services/BUILD.gn#newcode30 services/BUILD.gn:30: "//services/java_handler", On 2015/11/23 10:00:42, ppi wrote: > alphabetize Done. ...
5 years, 1 month ago (2015-11-23 10:08:44 UTC) #3
ppi
lgtm
5 years, 1 month ago (2015-11-23 10:09:30 UTC) #4
qsr
5 years, 1 month ago (2015-11-23 10:15:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
13402aaaddeae565561e60dd4f6a1b885b423d40 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698