Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1464293002: If Oilpan is enabled, warn of raw heap pointer fields by default. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

If Oilpan is enabled, warn of raw heap pointer fields by default. It is unsafe to keep fields with raw pointers into the Oilpan heap, as such untraced references risk going stale. With potentially undesirable consequences. Now that we've addressed and handled all such untraced references as part of Blink's transition to Oilpan, it is time to enable the clang GC plugin warning for such raw pointer uses. It shouldn't represent a major imposition to developers to handle such raw pointer uses correctly, but for now we will only emit a warning and not an error. R=haraken BUG=515524 Committed: https://crrev.com/3a192c385e0df065569291963b0aa8a1c992700f Cr-Commit-Position: refs/heads/master@{#361656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M tools/clang/scripts/blink_gc_plugin_flags.py View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 24 (9 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-23 09:38:17 UTC) #2
haraken
LGTM.
5 years, 1 month ago (2015-11-23 12:35:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464293002/1
5 years, 1 month ago (2015-11-23 19:59:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/121370)
5 years, 1 month ago (2015-11-23 20:33:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464293002/1
5 years ago (2015-11-24 18:39:29 UTC) #12
Nico
> It shouldn't represent a major imposition to developers to handle such > raw pointer ...
5 years ago (2015-11-24 18:45:17 UTC) #13
sof
On 2015/11/24 18:45:17, Nico wrote: > > It shouldn't represent a major imposition to developers ...
5 years ago (2015-11-24 18:50:56 UTC) #14
Nico
On 2015/11/24 18:45:17, Nico wrote: > > It shouldn't represent a major imposition to developers ...
5 years ago (2015-11-24 18:51:17 UTC) #15
Nico
On 2015/11/24 18:50:56, sof wrote: > On 2015/11/24 18:45:17, Nico wrote: > > > It ...
5 years ago (2015-11-24 18:54:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/121875)
5 years ago (2015-11-24 18:54:10 UTC) #18
sof
On 2015/11/24 18:54:07, Nico wrote: > On 2015/11/24 18:50:56, sof wrote: > > On 2015/11/24 ...
5 years ago (2015-11-24 19:01:33 UTC) #19
Nico
On 2015/11/24 19:01:33, sof wrote: > On 2015/11/24 18:54:07, Nico wrote: > > On 2015/11/24 ...
5 years ago (2015-11-24 19:07:39 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464293002/1
5 years ago (2015-11-25 15:06:07 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 15:11:29 UTC) #23
commit-bot: I haz the power
5 years ago (2015-11-25 15:12:24 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a192c385e0df065569291963b0aa8a1c992700f
Cr-Commit-Position: refs/heads/master@{#361656}

Powered by Google App Engine
This is Rietveld 408576698